#303: depcheck: error: Incorrect number of arguments ----------------------+----------------------------------------------------- Reporter: kparal | Owner: tflink Type: defect | Status: assigned Priority: critical | Milestone: 0.4.7 Component: tests | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by tflink):
Replying to [comment:3 kparal]:
My question is: If all builds are accepted, then why the depcheck test
was even triggered?
The test is scheduled because we don't determine the package's status until after the test is scheduled.
Possible solution: If someone edits an update, it re-applies the
-updates-pending tag, but we still detect it as accepted, if it passed previously? This way it can happen that everything "is accepted".
Hmm, that might be a different issue that we need to look into; I don't think that we handle that case right now. Currently, we get all accepted builds if our timing is right - ie, no new builds since last run, everything has passed so far and updates haven't been pushed to stable yet.
Replying to [comment:2 tflink]:
In my mind, the q-n-d fix for this would be to have depcheck run
without a non-zero exit code when it doesn't get any builds to test.
Easier solution would be probably to detect this in depcheck.py and not
run the command at all, just end the test with NEEDS_INSPECTION.
I don't think that either solution would be difficult to implement. I already have a 2 line patch up in review board to keep depcheck from exiting with non-zero status when all the builds are accepted - https://fedorahosted.org/reviewboard/r/135/
I didn't think about the update editing case, though so I'm not as sure that this alone is the best solution as I was 20 minutes ago.
I propose that we change depcheck for now and create a new ticket to handle the edited update use case.