I agree with James, I don't have any huge issues with the code
but it
does sound like a change to atest would be a better solution (if
approved, accepted etc.).
I see that Kamil has been talking with lmr on the github issue [1] -
do
we want to try fixing this ourselves and submitting a patch or do we
just wait to see what the resolution is?
My patch is so simple that I decided to act immediately no matter what the final
resolution is - it will bring us performance increase for almost no cost (just putting the
'noarch' label on all machines).
If Lucas decides to fix it and it ends up in the next version of autotest - great, we can
get rid of the extra label. If he doesn't fix it and someone from our team spends the
time on writing that patch - ok, same approach. If that issue is rejected, well, I see
bigger problems all around, this is just an inconvenience, I would live with that.
Any of those 3 scenarios doesn't seem to impact the included patch. Or do they?