#303: depcheck: error: Incorrect number of arguments ----------------------+----------------------------------------------------- Reporter: kparal | Owner: tflink Type: defect | Status: assigned Priority: critical | Milestone: 0.4.7 Component: tests | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by tflink):
Replying to [comment:7 jskladan]:
I'd prefer the second possibility. If nothing else, it seems better to
run depcheck just once, than to download the whole -pending tag just to test one package, which could have been already tested in the previous run.
After thinking about it a bit more, I'd like to propose a slightly different fix for the sort term: 1. Patch depcheck to not return a non-zero exit code if there are no pending builds * Submitted to reviewboard: https://fedorahosted.org/reviewboard/r/135/ 1. Patch depcheck.py so that it doesn't run ./depcheck if there are no pending builds * Submitted to reviewboard: https://fedorahosted.org/reviewboard/r/135/ * '''NOTE''': This patch isn't done. It does work in the strictest sense but messes with the reporting in a bad way. If we want to go this route, I'll fix it up and re-submit a proper fix tomorrow.
I figure that it would be good to have both as a short term fix. That way, both the command ./depcheck and the code that coordinates depcheck runs aren't behaving badly with empty inputs.
In the long term, I think that a fix for #248 could also fix this such that we don't have to worry about scheduling overlaps.