[Fedora Build Service] Review request

[Petr Schindler]

Hi,

I've made a quick fix to [1]. Here is the patch for review, you can find
it also attached to this mail.

[1] https://fedorahosted.org/fedora-build-service/ticket/9

---------------------PATCH-------------------------------------------

diff --git a/client/imagebuild.py b/client/imagebuild.py
index
78a29d4c6b7bb8cbae6c75f9178d8d11549f6410..1460a0611d32d01891b164aa7209e38b337c9752 100755
--- a/client/imagebuild.py
+++ b/client/imagebuild.py
@@ -102,7 +102,7 @@ def main():
                       type='choice',
                       choices=['boot','dvd','live'])
     parser.add_option('-w', '--workdir', help='Work directory for
the
image builder.', 
-                      dest='workdir',
default=tempfile.gettempdir()+'/imagebuilder_work')
+                      dest='workdir',
default='/var/tmp/imagebuilder_work')
     parser.add_option('-s', '--staging', help='Staging area
(file:///
or ftp://)', 
                       dest='staging', default='file:///'+os.getcwd())
     #parser.add_option('-e', '--email', help='Email address for
notification', dest='email')
@@ -120,6 +120,8 @@ def main():
         parser.print_help()
         sys.exit()
 
+    #TODO: write some warning if workdir is /tmp (in F18 and above)
+
     #check for config file path.
     if not os.path.exists(opts.config):
         sys.exit('Config file is non-existent')
diff --git a/conf/dvd_imagebuild.conf b/conf/dvd_imagebuild.conf
index
22ff578f5b9bb0cf5d2b11f0d8b2b93a6afb6993..89793343edc31bf942e0bc7cc95f76337228aa6a 100644
--- a/conf/dvd_imagebuild.conf
+++ b/conf/dvd_imagebuild.conf
@@ -16,8 +16,8 @@
config=file:///usr/share/spin-kickstarts/fedora-install-fedora.ks
 # sourceisos=0
 # force=1
 # stage=all (default)
-# destdir=/tmp/dvd_iso
-# cachedir=/tmp/dvd_iso/cache
+# destdir=/var/tmp/dvd_iso
+# cachedir=/var/tmp/dvd_iso/cache
 
 # Additional packages to retrieve from Koji
 # Seperated by semicolons;
diff --git a/conf/live_imagebuild.conf b/conf/live_imagebuild.conf
index
551d71ef9828ab7d961eb1e1e32cb1cf6a2f45e9..a5ff4877e12c3e0ebb62e915610ce860c8bf190f 100644
--- a/conf/live_imagebuild.conf
+++ b/conf/live_imagebuild.conf
@@ -18,9 +18,9 @@
config=http://git.fedorahosted.org/cgit/spin-kickstarts.git/tree/fedora-l...
 # releasever=rawhide
 # nvr=
 # bid=
-# tmpdir=/tmp/livework
+# tmpdir=/var/tmp/livework
 # cachedir=/var/cache/liveimage
-# logfile=/tmp/liveimage.log
+# logfile=/var/tmp/liveimage.log
 
 # Additional packages to retrieve from Koji
 # Seperated by semicolons;