#207: post-koji-build watcher does not watch for new updates-candidate builds ----------------------+----------------------------------------------------- Reporter: kparal | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: watchers | Version: 1.0 Keywords: | ----------------------+----------------------------------------------------- I have found out that our post-koji-build watches only these tags:
dist-f10 dist-f10-updates dist-f10-updates-testing dist-f11 dist-f11-updates dist-f11-updates-testing dist-f12 dist-f12-updates dist-f12-updates-testing dist-f13 dist-f13-updates dist-f13-updates- testing dist-f14
Which is incorrect, we should be watching dist-f*-updates-candidate (and maybe dist-f14, I don't know). We don't need to watch for the rest of it.
The change happened in commit 580734d4f2aa768aefa1c0498904df2296747918. See the diff and inspect current contents of repoinfo.conf to grasp the change.
The result is that we don't currently test almost any packages except f14 ones. Do we have it already deployed on our production machine?
What we can do about it? Well, I hope someone with a deep understanding of repoinfo stuff knows what's the best approach :) It seems to me that we could define the *-updates-testing repositories in repoinfo.conf (and make sure we didn't break something else) and retrieve and select just those in watch-koji-builds.
#207: post-koji-build watcher does not watch for new updates-candidate builds -----------------------+---------------------------------------------------- Reporter: kparal | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: watchers | Version: 1.0 Resolution: | Keywords: -----------------------+---------------------------------------------------- Comment (by jlaska):
Replying to [ticket:207 kparal]:
I have found out that our post-koji-build watches only these tags:
dist-f10 dist-f10-updates dist-f10-updates-testing dist-f11
dist-f11-updates dist-f11-updates-testing dist-f12 dist-f12-updates dist-f12-updates-testing dist-f13 dist-f13-updates dist-f13-updates- testing dist-f14
Which is incorrect, we should be watching dist-f*-updates-candidate (and
maybe dist-f14, I don't know). We don't need to watch for the rest of it.
The change happened in commit 580734d4f2aa768aefa1c0498904df2296747918.
See the diff and inspect current contents of repoinfo.conf to grasp the change.
Uh oh, that's my commit :( Great catch.
I thought we ironed this out when we revised repoinfo.conf and cleaned up the koji watcher methods. But I recall thinking that this was another hook that could use a test framework to aid in validating changes (different topic). I'm seeing fc14, fc13 and fc12 builds on autoqa- results@lists.fedorahosted.org. But as you point out, the hook is skipping any dist-f*-updates-candidate builds. I *wonder* if this is intentional for the hook but I could be very wrong.
Since I always have a hard time walking through the koji and bodhi hooks, where the test data changes constantly, I added some extra debugging to the hook to find a sample build. A good sample build that was skipped is [http://koji.fedoraproject.org/koji/buildinfo?buildID=181071 fwbackups-1.43.3-0.9.rc5.fc12] (tag: dist-f12-updates-testing). This build was submitted to F12 updates-testing, and pushed on 2010-07-05 (see [https://admin.fedoraproject.org/updates/fwbackups-1.43.3-0.9.rc5.fc12 bodhi]).
A *quick* fix is to add config sections to repoinfo.conf for [f13-updates- candidate]. While in my testing this includes the desired builds, I'm not sure that's the right fix since repoinfo is for package repositories, and there is no updates-candidate repository.
The result is that we don't currently test almost any packages except
f14 ones. Do we have it already deployed on our production machine?
Yes, v0.3.5 includes this change (http://git.fedorahosted.org/git/?p=autoqa.git;a=shortlog;h=refs/tags/v0.3.5-...).
#207: post-koji-build watcher does not watch for new updates-candidate builds -----------------------+---------------------------------------------------- Reporter: kparal | Owner: Type: defect | Status: new Priority: major | Milestone: Hot issues Component: watchers | Version: 1.0 Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by kparal):
* milestone: Package Update Acceptance Test Plan => Hot issues
#207: post-koji-build watcher does not watch for new updates-candidate builds -----------------------+---------------------------------------------------- Reporter: kparal | Owner: jlaska Type: defect | Status: new Priority: major | Milestone: Hot issues Component: watchers | Version: 1.0 Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by jlaska):
* owner: => jlaska
Comment:
Taking ownership. I've corrected this issue. Watch autoqa-devel for a patch.
--- hooks/post-koji-build/watch-koji-builds.py | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/hooks/post-koji-build/watch-koji-builds.py b/hooks/post-koji-build/watch-koji-builds.py index 1b3a17b..3a8ad23 100755 --- a/hooks/post-koji-build/watch-koji-builds.py +++ b/hooks/post-koji-build/watch-koji-builds.py @@ -111,7 +111,12 @@ tags for new builds and kick off tests when new builds/packages are found.') # Using repoinfo, establish the set of tags to look for taglist = set() for repo in repoinfo.repos(): - taglist.add(repoinfo.get(repo, 'tag')) + # include tag the development branch (aka rawhide) + if repoinfo.get(repo, 'collection_name') == "devel": + taglist.add(repoinfo.get(repo, 'tag')) + # otherwise, find all *-updates-candidate tags to include + elif len(repoinfo.getparents(repo)) == 0: + taglist.add(repoinfo.get(repo, 'tag') + '-updates-candidate')
if opts.verbose: print "Looking up builds since %s (%s)" % (opts.prevtime, time.ctime(opts.prevtime)) @@ -145,6 +150,11 @@ tags for new builds and kick off tests when new builds/packages are found.') testarches.discard('noarch') testarches.add('x86_64')
+ # Account for mismatched 32-bit repo and package architecture + # name ('i386' vs 'i686') + if 'i386' in repoarches and 'i686' in arches: + testarches.add('i686') + for arch in testarches: harnesscall += ['--arch', arch] if b['epoch']:
#207: post-koji-build watcher does not watch for new updates-candidate builds -----------------------+---------------------------------------------------- Reporter: kparal | Owner: jlaska Type: defect | Status: closed Priority: major | Milestone: Hot issues Component: watchers | Version: 1.0 Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by kparal):
* status: new => closed * resolution: => fixed
Comment:
This has been pushed to master few days ago. Thanks jlaska!
autoqa-devel@lists.fedorahosted.org
-
fedora-badges -
James Laska