#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.5.0 Component: core | Keywords: -------------------------+-------------------------------------------------- Some of our modules have unit tests. Let's execute them all by "make test" command and report the result. We can use this functionality to periodically check whether nothing got broken.
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by kparal):
mkrizek tried to implement this, his code is in the 'maketest' branch
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by jlaska):
Tim ... does this ticket fall into the unittest and py.test work you are doing?
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: tflink Type: enhancement | Status: assigned Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by tflink):
* owner: => tflink * status: new => assigned
Comment:
Yeah, eventually I want to get everything integrated with 'make test'
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: tflink Type: enhancement | Status: assigned Priority: minor | Milestone: 0.5.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by kparal):
* priority: major => minor
Comment:
We prefer to have the plumbing/framework in place for 0.5.0 with some basic tests (or existing tests) implemented. That does not include large refactoring of existing classes (that can come later).
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: tflink Type: enhancement | Status: assigned Priority: minor | Milestone: Nice to have soon Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by tflink):
I wasn't planning to do this now, but ended up writing a bunch of tests for #314 and have an initial form of 'make test' in the tflink branch -df3d9cb12df3f6324eb9c7d9005c5eb7a6263f02
I recycled a lot of stuff from the proof-of-concept that I did earlier but without the disruptive refactoring.
You still need to have python-pip and python-virtualenv installed in order for this to work. The first time that you run this, it will take a while as it downloads dependencies.
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: tflink Type: enhancement | Status: closed Priority: minor | Milestone: Nice to have soon Component: core | Resolution: fixed Keywords: | -------------------------+-------------------------------------------------- Changes (by tflink):
* status: assigned => closed * resolution: => fixed
Comment:
Initial code has been reviewed and pushed to master
613fa26bf144e2c90146344c686cd01eeeca1939
This still doesn't execute all of the unit tests, though
#258: implement 'make test' -------------------------+-------------------------------------------------- Reporter: kparal | Owner: tflink Type: enhancement | Status: closed Priority: minor | Milestone: 0.5.0 Component: core | Resolution: fixed Keywords: | -------------------------+-------------------------------------------------- Changes (by kparal):
* milestone: Nice to have soon => 0.5.0
Comment:
Tim, I currently don't know exactly which unit tests we have but don't execute them, and whether they are available in master or just in maketest branch. Could you please file a new fingerfood(?) ticket about integrating those remaining unit tests into our new test framework (re-writing them if necessary), and make a list of them there? Thanks.
#258: implement 'make test' ---------------------------+------------------------------------------------ Reporter: kparal | Owner: tflink Type: enhancement | Status: closed Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: fixed Keywords: | ---------------------------+------------------------------------------------ Changes (by kparal):
* component: core => documentation
Comment:
One more thing, maybe we would like to document this behavior in our development process somewhere on wiki. Changing to documentation component until we do that.
#258: implement 'make test' ---------------------------+------------------------------------------------ Reporter: kparal | Owner: tflink Type: enhancement | Status: reopened Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Changes (by tflink):
* status: closed => reopened * resolution: fixed =>
Comment:
#340 was created to integrate depcheck tests into the main test suite. They might need refactoring to make them more useful but at least we have a ticket to keep track of them.
Also, re-opening since documentation still isn't done.
#258: implement 'make test' ---------------------------+------------------------------------------------ Reporter: kparal | Owner: tflink Type: enhancement | Status: reopened Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by tflink):
Initial documentation is up on the wiki:
https://fedoraproject.org/wiki/User:Tflink/Sandbox:AutoQA_Self_Testing
It doesn't feel quite done to me yet, I'm planning to go over it again next week before moving it to a more permanent page (not sandbox).
#258: implement 'make test' ---------------------------+------------------------------------------------ Reporter: kparal | Owner: tflink Type: enhancement | Status: reopened Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by kparal):
I have added a plea to run tests into this document:
https://fedoraproject.org/w/index.php?title=AutoQA_Patch_Process&action=...
#258: implement 'make test' ---------------------------+------------------------------------------------ Reporter: kparal | Owner: tflink Type: enhancement | Status: closed Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: fixed Keywords: | ---------------------------+------------------------------------------------ Changes (by tflink):
* status: reopened => closed * resolution: => fixed
Comment:
It's done for now and moved to:
https://fedoraproject.org/wiki/AutoQA_Self_Testing
autoqa-devel@lists.fedorahosted.org
-
fedora-badges