On 06/08/2011 04:15 AM, Kamil Paral wrote:
Here's the current situation. The code is ready. We need to
properly, that will cause slight changes (already happening for Tim's
patch). Once the reviews are ready, we need to merge it (that
shouldn't be a problem) and test it properly.
Josef is ill. Vita is preparing for state exam. That leaves all the
work up to me and Tim, and maybe James if he has some spare time.
James, I think you have some machine with setup similar to our
production server, where you can have the code running for a few
days, right? That would help with the testing stage.
Otherwise, I have a pseudo-production setup here. ATM, I only have
x86_64 test hosts set up but can change that without too much effort.
Whether my network bandwidth can keep up with a full test setup or not
is a different question, though :)
Tim, before we reach the testing stage, I would like to discuss with
you what the current process should be like. I've seen your patch and
it's much shorter and isolated (not impacting many files) than the
pretty patch, so I would like to merge it first. Provided that you
are able to make the required changes (according to the review) in
the following few days. In the meantime I can continue testing pretty
patch, polishing HTML output or start creating documentation. Once
your patch is merged, we will both work on reviewing pretty patch 
and merging it. Then the final testing begins. Does it sound like a
plan? Other ideas?
That sounds like a plan to me. I've started making the changes and
should be able to finish today. The other option would be to merge the
email reduction stuff into the pretty branch, but I'm not sure that
would be a better way to do things.
I'm still not sure how to best test the email reduction stuff since its
so tightly coupled to bodhi state and will usually say "comment not
needed" unless the timing is good and we beat production. I don't like
saying this but we may have to rely on our mascot for that one and hope
that my unit tests covered everything.
 I'll probably try to load the pretty patch into reviewboard
well. Even though it's quite large and it will load really long, it's
probably easier to read and to discuss particular lines than using
Thanks, I've started looking at the patch and was trying to figure out
the best way to view and provide comments. Some of the changes weren't
incredibly clear when I tried doing difftool with meld. It'll be a good
test of RB's ability to handle large patches.