#167: Initscript review: mcstrans ----------------------+----------------------------------------------------- Reporter: jskladan | Owner: Type: task | Status: new Priority: minor | Milestone: Initscripts review Component: tests | Version: 1.0 Keywords: | ----------------------+----------------------------------------------------- Check the test according to the https://fedorahosted.org/autoqa/wiki/initscripts
#167: Initscript review: mcstrans ----------------------+----------------------------------------------------- Reporter: jskladan | Owner: jskladan Type: task | Status: new Priority: minor | Milestone: Initscripts review Component: tests | Resolution: Keywords: | ----------------------+----------------------------------------------------- Changes (by mkrizek):
* owner: => jskladan
Comment:
Seems ok to me except the wrong lock file name, which is according to /etc/init.d/mcstrans now named /var/lock/subsys/mcstransd. Renaming the file eases off one "FAIL" result. Also, the initscript does not implement all the required actions mentioned in https://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions, therefore they are not all present in the test (maybe there should be a warning message of some sort).
#167: Initscript review: mcstrans ----------------------+----------------------------------------------------- Reporter: jskladan | Owner: mkrizek Type: task | Status: new Priority: minor | Milestone: Initscripts review Component: tests | Resolution: Keywords: | ----------------------+----------------------------------------------------- Changes (by jskladan):
* owner: jskladan => mkrizek
#167: Initscript review: mcstrans ----------------------+----------------------------------------------------- Reporter: jskladan | Owner: mkrizek Type: task | Status: closed Priority: minor | Milestone: Initscripts review Component: tests | Resolution: fixed Keywords: | ----------------------+----------------------------------------------------- Changes (by mkrizek):
* status: new => closed * resolution: => fixed
Comment:
Pushed into master.
autoqa-devel@lists.fedorahosted.org