tests/conflicts/potential_conflict.py failed to run,line 191 changed

[Li Ming]

Hi,

   When run case: 
https://fedoraproject.org/wiki/QA:Testcase_Mediakit_FileConflicts,
the script was failed, I modified line 191

Thanks
Liam

[James Laska]

On Tue, 2010-01-05 at 16:57 +0800, Li Ming wrote:
>  Hi,
>  
>     When run case: 
>  https://fedoraproject.org/wiki/QA:Testcase_Mediakit_FileConflicts,
>  the script was failed, I modified line 191 
Thanks for the patch Liam.

Can you describe the failure you encountered that is resolved by
adjusting line#191?

Thanks,
James

[Li Ming]

On 01/07/2010 01:12 AM, James Laska wrote:
>  On Tue, 2010-01-05 at 16:57 +0800, Li Ming wrote:
> > Hi,
> >
> >     When run case:
> > https://fedoraproject.org/wiki/QA:Testcase_Mediakit_FileConflicts,
> > the script was failed, I modified line 191
>
>  Thanks for the patch Liam.
>
>  Can you describe the failure you encountered that is resolved by
>  adjusting line#191?
>  
This is the out put when I run the above case:
[root@localhost conflicts]# python ./potential_conflict.py 
--repofrompath=media,/media -a i386 -r media
Traceback (most recent call last):
   File "./potential_conflict.py", line 191, in <module>
     my.repos.setCacheDir(cachedir)
NameError: name 'cachedir' is not defined

After adjusted line 191, the output is:

[root@localhost conflicts]# python ./potential_conflict.py 
--repofrompath=media,/media -a i386 -r media
Getting complete filelist for:
file:///media/
390687 files found.

Looking for duplicated filenames:
77 duplicates found.

Doing more advanced checks to see if these are real conflicts:
   4% complete (     3/    77,    49/sec),    0 found - eta 0:00:01
   8% complete (     6/    77,  7918/sec),    0 found - eta 0:00:00
  12% complete (     9/    77,  1230/sec),    0 found - eta 0:00:00
  16% complete (    12/    77,   401/sec),    0 found - eta 0:00:00
  19% complete (    15/    77, 23431/sec),    0 found - eta 0:00:00
  23% complete (    18/    77, 39444/sec),    0 found - eta 0:00:00
  27% complete (    21/    77, 77195/sec),    0 found - eta 0:00:00
  31% complete (    24/    77,   447/sec),    0 found - eta 0:00:00
  35% complete (    27/    77,   858/sec),    0 found - eta 0:00:00
  39% complete (    30/    77,   885/sec),    0 found - eta 0:00:00
  43% complete (    33/    77, 30916/sec),    0 found - eta 0:00:00
  47% complete (    36/    77,   767/sec),    0 found - eta 0:00:00
  51% complete (    39/    77,   872/sec),    0 found - eta 0:00:00
  55% complete (    42/    77, 11027/sec),    0 found - eta 0:00:00
  58% complete (    45/    77, 62601/sec),    0 found - eta 0:00:00
  62% complete (    48/    77, 81180/sec),    0 found - eta 0:00:00
  66% complete (    51/    77, 12761/sec),    0 found - eta 0:00:00
  70% complete (    54/    77,   891/sec),    0 found - eta 0:00:00
  74% complete (    57/    77,   766/sec),    0 found - eta 0:00:00
  78% complete (    60/    77, 34473/sec),    0 found - eta 0:00:00
  82% complete (    63/    77, 39945/sec),    0 found - eta 0:00:00
  86% complete (    66/    77, 20426/sec),    0 found - eta 0:00:00
  90% complete (    69/    77,  1751/sec),    0 found - eta 0:00:00
  94% complete (    72/    77, 24769/sec),    0 found - eta 0:00:00
  97% complete (    75/    77, 73584/sec),    0 found - eta 0:00:00
0 file conflicts found.
0 package conflicts found.

== Package conflicts ==

== File conflicts, listed by conflicting packages ==

Thanks
Liam

[Kamil Paral]

----- "Li Ming" <lili(a)redhat.com&gt; wrote:
>  This is the out put when I run the above case:
>  [root@localhost conflicts]# python ./potential_conflict.py 
>  --repofrompath=media,/media -a i386 -r media
>  Traceback (most recent call last):
>     File "./potential_conflict.py", line 191, in <module>
>       my.repos.setCacheDir(cachedir)
>  NameError: name 'cachedir' is not defined
>   
The line is really wrongly indented, but I leave the fix up to
wwoods, because I have no expertise in that script. Thanks
for finding out.

[James Laska]

On Thu, 2010-01-07 at 03:59 -0500, Kamil Paral wrote:
>  ----- "Li Ming" <lili(a)redhat.com&gt; wrote:
>  > This is the out put when I run the above case:
>  > [root@localhost conflicts]# python ./potential_conflict.py 
>  > --repofrompath=media,/media -a i386 -r media
>  > Traceback (most recent call last):
>  >    File "./potential_conflict.py", line 191, in <module>
>  >      my.repos.setCacheDir(cachedir)
>  > NameError: name 'cachedir' is not defined
>  > 
>  
>  The line is really wrongly indented, but I leave the fix up to
>  wwoods, because I have no expertise in that script. Thanks
>  for finding out. 
Oh I see now, I wasn't running the test as root.  Running as root for me
results in the failure Liam posted.

Thanks,
James