Re: depcheck - next steps!

[Kamil Paral]

----- "Will Woods"  wrote:
> == write control/control.autoqa/test wrapper object ==
>
> I took a stab at this in the depcheck branch but I'm pretty sure I
> did
> it wrong / left some stuff out. Kamil/Joza, if you guys can give me
> some
> help/pointers here I'd appreciate it... but don't worry, I'll send
> the
> patch to the list for a final review before I merge anything.

I'm a little confused by all those files in tests/depcheck. There is
* depcheck
* depcheck.py
* depcheck_test.py

By our conventions the AutoQA test object should be called "depcheck.py".
Therefore we need to rename the actual script to something else, like
"run_depcheck.py" or similar.

It's not clear to me what the purpose of the current 'depcheck' file is,
I think its functionality can be easily integrated into the main depcheck
script itself (the one with proposed name "run_depcheck.py"), can't it?

depcheck - next steps!

[Will Woods]

On Wed, 2010-08-25 at 05:48 -0400, Kamil Paral wrote:
> I'm a little confused by all those files in tests/depcheck. There is
> depcheck
> depcheck.py
> depcheck_test.py
>
> By our conventions the AutoQA test object should be called "depcheck.py".
> Therefore we need to rename the actual script to something else, like
> "run_depcheck.py" or similar.

The actual main script/CLI frontend is "depcheck". "depcheck.py" is a
python module that contains the methods etc. used by depcheck, and the
depcheck unittests.

I split it up because it was getting really messy having everything in
one big file - and because I thought some other test / code might want
to import and use chunks of depcheck in the future.

But maybe I was a little hasty in splitting things. For now, everything
can just live in the main 'depcheck' file. When we actually want the
'depcheck' code to be shareable, we can move the shared parts to
lib/python/depcheck.py.

I'll revert those changes accordingly.

-w