#409: make test does not work -----------------------+------------------------ Reporter: mkrizek | Owner: tflink Type: defect | Status: new Priority: critical | Milestone: Hot issues Component: core | Keywords: Blocked By: | Blocking: -----------------------+------------------------ make test does not work any more, fails with:
{{{ Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/pip/runner.py", line 16, in <module> exit = run() File "/usr/lib/python2.7/site-packages/pip/runner.py", line 11, in run import pip File "/usr/lib/python2.7/site-packages/pip/__init__.py", line 10, in <module> from pip.basecommand import command_dict, load_command, load_all_commands, command_names File "/usr/lib/python2.7/site-packages/pip/basecommand.py", line 11, in <module> from pip.baseparser import parser, ConfigOptionParser, UpdatingDefaultsHelpFormatter File "/usr/lib/python2.7/site-packages/pip/baseparser.py", line 5, in <module> import pkg_resources File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 2727, in <module> add_activation_listener(lambda dist: dist.activate()) File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 700, in subscribe callback(dist) File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 2727, in <lambda> add_activation_listener(lambda dist: dist.activate()) File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 2230, in activate map(declare_namespace, self._get_metadata('namespace_packages.txt')) File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 1815, in declare_namespace path = sys.modules[parent].__path__ KeyError: 'peak' }}}
It fails on: pip-python -E test_env/ install ''package''
I found out that it is possibly somehow connected to -E option, since running it without that option works fine.
This issue is kind of critical as it blocks building AutoQA package (we run make test in %check section).
#409: make test does not work ----------------------+------------------------- Reporter: mkrizek | Owner: tflink Type: defect | Status: new Priority: critical | Milestone: Hot issues Component: core | Resolution: Keywords: | Blocked By: Blocking: | ----------------------+-------------------------
Comment (by tflink):
I was wondering when this was going to break. There have been some changes in pip and virtualenv that make the runtests.sh script not work anymore. * pip -E doesn't work any more * virtualenv does --no-site-packages by default now (not shown in this error message)
I can fix the script so that it works again but this was originally a workaround for the lack of recent py.test in the fedora repos (fixed in F16+). I'd like to change the setup so that it isn't quite so dirty-hacky but I'm also thinking that it would be better to wait for that until after we figure out what's going on with the test/lib decoupling that's been proposed.
Unless there are objections, I'm going to fix the hacky-script for now and file a new ticket to get rid of the stupid thing.
#409: make test does not work ----------------------+------------------------- Reporter: mkrizek | Owner: tflink Type: defect | Status: new Priority: critical | Milestone: Hot issues Component: core | Resolution: Keywords: | Blocked By: Blocking: | ----------------------+-------------------------
Comment (by kparal):
Replying to [comment:1 tflink]:
I'm also thinking that it would be better to wait for that until after
we figure out what's going on with the test/lib decoupling that's been proposed.
Does it have any impact on that? We currently test only a few library functions, nothing else, right?
#409: make test does not work ----------------------+------------------------- Reporter: mkrizek | Owner: tflink Type: defect | Status: new Priority: critical | Milestone: Hot issues Component: core | Resolution: Keywords: | Blocked By: Blocking: | ----------------------+-------------------------
Comment (by tflink):
Replying to [comment:2 kparal]:
Replying to [comment:1 tflink]: Does it have any impact on that? We currently test only a few library
functions, nothing else, right?
It really depends on how we end up doing the decoupling and how far we go. The changes would mostly be moving files around and changing scripts to be less hack-ish. Since we may be moving stuff around for the decoupling, I'd rather re-write the self-test stuff once instead of twice.
#409: make test does not work ----------------------+------------------------- Reporter: mkrizek | Owner: tflink Type: defect | Status: assigned Priority: critical | Milestone: Hot issues Component: core | Resolution: Keywords: | Blocked By: Blocking: | ----------------------+------------------------- Changes (by tflink):
* status: new => assigned
Comment:
It turns out that there were some broken tests hiding behind the non- functional runner script.
I fixed the runner script and the broken tests that were hiding.
https://fedorahosted.org/reviewboard/r/260/
#409: make test does not work ----------------------+------------------------- Reporter: mkrizek | Owner: tflink Type: defect | Status: assigned Priority: critical | Milestone: Hot issues Component: core | Resolution: Keywords: | Blocked By: Blocking: | ----------------------+-------------------------
Comment (by kparal):
Reviewed.
#409: make test does not work ----------------------+------------------------- Reporter: mkrizek | Owner: tflink Type: defect | Status: closed Priority: critical | Milestone: Hot issues Component: core | Resolution: fixed Keywords: | Blocked By: Blocking: | ----------------------+------------------------- Changes (by tflink):
* status: assigned => closed * resolution: => fixed
Comment:
Pushed to master: * 2e93bace3ae0de46f7b5af7b13cdf0b40c2bdd7b
autoqa-devel@lists.fedorahosted.org
-
fedora-badges