Review Request 6: Fixing sync to work with new python-bugzilla and new FE naming convention

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/
-----------------------------------------------------------

Review request for blockerbugs.


Bugs: 331
    https://fedorahosted.org/fedora-qa/ticket/331


Repository: blockerbugs


Description
-------

Refactoring templates, bug sync and database to fit with new FreezeException nomenclature
adding alembic upgrade script for db changes
updated bug_sync code for python-bugzilla >= 0.8


Diffs
-----

  testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
  testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
  setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
  blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3 
  blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
  blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
  blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
  blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
  blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
  blockerbugs/templates/admin/modify_release.html 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90

  blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
  blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
  blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
  blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
  blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
  blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
  blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
  alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
  alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/


Testing
-------

I've done several syncs on both sqlite and postgres dbs and clicked around to make
sure that all the templates that _were_ working are still working. Some of the admin pages
still have issues but that is orthogonal to the changes here.

I did an alembic upgrade of the database with no issues.


Thanks,

Tim Flink

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/#review2
-----------------------------------------------------------



blockerbugs/util/bz_interface.py
<http://reviewboard-tflink.rhcloud.com/r/6/#comment1>

    I suppose this is a leftover from testing the code, right?


- Martin Krizek


On Feb. 18, 2013, 9:30 p.m., Tim Flink wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-tflink.rhcloud.com/r/6/
>  -----------------------------------------------------------
>  
>  (Updated Feb. 18, 2013, 9:30 p.m.)
>  
>  
>  Review request for blockerbugs.
>  
>  
>  Bugs: 331
>      https://fedorahosted.org/fedora-qa/ticket/331
>  
>  
>  Repository: blockerbugs
>  
>  
>  Description
>  -------
>  
>  Refactoring templates, bug sync and database to fit with new FreezeException
> nomenclature
>  adding alembic upgrade script for db changes
>  updated bug_sync code for python-bugzilla >= 0.8
>  
>  
>  Diffs
>  -----
>  
>    testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
>    testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
>    setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
>    blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3 
>    blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
>    blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
>    blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
>    blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
>    blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
>    blockerbugs/templates/admin/modify_release.html
> 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90 
>    blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
>    blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
>    blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
>    blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
>    blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
>    blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
>    blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
>    alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
>    alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 
>  
>  Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/
>  
>  
>  Testing
>  -------
>  
>  I've done several syncs on both sqlite and postgres dbs and clicked around to make
> sure that all the templates that _were_ working are still working. Some of the admin pages
> still have issues but that is orthogonal to the changes here.
>  
>  I did an alembic upgrade of the database with no issues.
>  
>  
>  Thanks,
>  
>  Tim Flink
>  
>

[Martin Krizek]

>  On Feb. 19, 2013, 2:59 p.m., Martin Krizek wrote:
>  > blockerbugs/util/bz_interface.py, line 42
>  > <http://reviewboard-tflink.rhcloud.com/r/6/diff/1/?file=83#file83line42>
>  >
>  >     I suppose this is a leftover from testing the code, right? 
Oops, sorry about the opened issue.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/#review2
-----------------------------------------------------------


On Feb. 18, 2013, 9:30 p.m., Tim Flink wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-tflink.rhcloud.com/r/6/
>  -----------------------------------------------------------
>  
>  (Updated Feb. 18, 2013, 9:30 p.m.)
>  
>  
>  Review request for blockerbugs.
>  
>  
>  Bugs: 331
>      https://fedorahosted.org/fedora-qa/ticket/331
>  
>  
>  Repository: blockerbugs
>  
>  
>  Description
>  -------
>  
>  Refactoring templates, bug sync and database to fit with new FreezeException
> nomenclature
>  adding alembic upgrade script for db changes
>  updated bug_sync code for python-bugzilla >= 0.8
>  
>  
>  Diffs
>  -----
>  
>    testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
>    testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
>    setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
>    blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3 
>    blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
>    blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
>    blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
>    blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
>    blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
>    blockerbugs/templates/admin/modify_release.html
> 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90 
>    blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
>    blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
>    blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
>    blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
>    blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
>    blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
>    blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
>    alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
>    alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 
>  
>  Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/
>  
>  
>  Testing
>  -------
>  
>  I've done several syncs on both sqlite and postgres dbs and clicked around to make
> sure that all the templates that _were_ working are still working. Some of the admin pages
> still have issues but that is orthogonal to the changes here.
>  
>  I did an alembic upgrade of the database with no issues.
>  
>  
>  Thanks,
>  
>  Tim Flink
>  
>

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/#review4
-----------------------------------------------------------



blockerbugs/util/bz_interface.py
<http://reviewboard-tflink.rhcloud.com/r/6/#comment3>

    actually, that was me testing to make sure the code would work with both bugzilla
versions. It didn't make it into git but it was on my local machine when I generated
the diff. will update


- Tim Flink


On Feb. 18, 2013, 9:30 p.m., Tim Flink wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-tflink.rhcloud.com/r/6/
>  -----------------------------------------------------------
>  
>  (Updated Feb. 18, 2013, 9:30 p.m.)
>  
>  
>  Review request for blockerbugs.
>  
>  
>  Bugs: 331
>      https://fedorahosted.org/fedora-qa/ticket/331
>  
>  
>  Repository: blockerbugs
>  
>  
>  Description
>  -------
>  
>  Refactoring templates, bug sync and database to fit with new FreezeException
> nomenclature
>  adding alembic upgrade script for db changes
>  updated bug_sync code for python-bugzilla >= 0.8
>  
>  
>  Diffs
>  -----
>  
>    testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
>    testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
>    setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
>    blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3 
>    blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
>    blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
>    blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
>    blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
>    blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
>    blockerbugs/templates/admin/modify_release.html
> 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90 
>    blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
>    blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
>    blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
>    blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
>    blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
>    blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
>    blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
>    alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
>    alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 
>  
>  Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/
>  
>  
>  Testing
>  -------
>  
>  I've done several syncs on both sqlite and postgres dbs and clicked around to make
> sure that all the templates that _were_ working are still working. Some of the admin pages
> still have issues but that is orthogonal to the changes here.
>  
>  I did an alembic upgrade of the database with no issues.
>  
>  
>  Thanks,
>  
>  Tim Flink
>  
>

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/
-----------------------------------------------------------

(Updated Feb. 19, 2013, 3:51 p.m.)


Review request for blockerbugs.


Changes
-------

Updating diff to not have leftover artifacts from my dev environment


Bugs: 331
    https://fedorahosted.org/fedora-qa/ticket/331


Repository: blockerbugs


Description
-------

Refactoring templates, bug sync and database to fit with new FreezeException nomenclature
adding alembic upgrade script for db changes
updated bug_sync code for python-bugzilla >= 0.8


Diffs (updated)
-----

  testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
  testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
  setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
  blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
  blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
  blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
  blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
  blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
  blockerbugs/templates/admin/modify_release.html 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90

  blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
  blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
  blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
  blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
  blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
  blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
  blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
  alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
  alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/


Testing
-------

I've done several syncs on both sqlite and postgres dbs and clicked around to make
sure that all the templates that _were_ working are still working. Some of the admin pages
still have issues but that is orthogonal to the changes here.

I did an alembic upgrade of the database with no issues.


Thanks,

Tim Flink

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/#review5
-----------------------------------------------------------



blockerbugs/util/bug_sync.py
<http://reviewboard-tflink.rhcloud.com/r/6/#comment4>

    I am wondering if it would be better to use exc.SQLAlchemyError instead of Exception.


- Martin Krizek


On Feb. 19, 2013, 3:51 p.m., Tim Flink wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-tflink.rhcloud.com/r/6/
>  -----------------------------------------------------------
>  
>  (Updated Feb. 19, 2013, 3:51 p.m.)
>  
>  
>  Review request for blockerbugs.
>  
>  
>  Bugs: 331
>      https://fedorahosted.org/fedora-qa/ticket/331
>  
>  
>  Repository: blockerbugs
>  
>  
>  Description
>  -------
>  
>  Refactoring templates, bug sync and database to fit with new FreezeException
> nomenclature
>  adding alembic upgrade script for db changes
>  updated bug_sync code for python-bugzilla >= 0.8
>  
>  
>  Diffs
>  -----
>  
>    testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
>    testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
>    setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
>    blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
>    blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
>    blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
>    blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
>    blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
>    blockerbugs/templates/admin/modify_release.html
> 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90 
>    blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
>    blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
>    blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
>    blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
>    blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
>    blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
>    blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
>    alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
>    alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 
>  
>  Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/
>  
>  
>  Testing
>  -------
>  
>  I've done several syncs on both sqlite and postgres dbs and clicked around to make
> sure that all the templates that _were_ working are still working. Some of the admin pages
> still have issues but that is orthogonal to the changes here.
>  
>  I did an alembic upgrade of the database with no issues.
>  
>  
>  Thanks,
>  
>  Tim Flink
>  
>

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/#review7
-----------------------------------------------------------



blockerbugs/util/bug_sync.py
<http://reviewboard-tflink.rhcloud.com/r/6/#comment9>

    Actually, I'm not even sure that should still be there. I added that for debugging
purposes and I can't think of anything that would be helped by leaving it there (would
leave around bad transactions which would need to be rolled back). Will remove - good
catch


- Tim Flink


On Feb. 19, 2013, 3:51 p.m., Tim Flink wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-tflink.rhcloud.com/r/6/
>  -----------------------------------------------------------
>  
>  (Updated Feb. 19, 2013, 3:51 p.m.)
>  
>  
>  Review request for blockerbugs.
>  
>  
>  Bugs: 331
>      https://fedorahosted.org/fedora-qa/ticket/331
>  
>  
>  Repository: blockerbugs
>  
>  
>  Description
>  -------
>  
>  Refactoring templates, bug sync and database to fit with new FreezeException
> nomenclature
>  adding alembic upgrade script for db changes
>  updated bug_sync code for python-bugzilla >= 0.8
>  
>  
>  Diffs
>  -----
>  
>    testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
>    testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
>    setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
>    blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
>    blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
>    blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
>    blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
>    blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
>    blockerbugs/templates/admin/modify_release.html
> 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90 
>    blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
>    blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
>    blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
>    blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
>    blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
>    blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
>    blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
>    alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
>    alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 
>  
>  Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/
>  
>  
>  Testing
>  -------
>  
>  I've done several syncs on both sqlite and postgres dbs and clicked around to make
> sure that all the templates that _were_ working are still working. Some of the admin pages
> still have issues but that is orthogonal to the changes here.
>  
>  I did an alembic upgrade of the database with no issues.
>  
>  
>  Thanks,
>  
>  Tim Flink
>  
>

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/
-----------------------------------------------------------

(Updated Feb. 22, 2013, 2:28 p.m.)


Review request for blockerbugs.


Changes
-------

Updating review to fix issue found with not-needed try/except


Bugs: 331
    https://fedorahosted.org/fedora-qa/ticket/331


Repository: blockerbugs


Description
-------

Refactoring templates, bug sync and database to fit with new FreezeException nomenclature
adding alembic upgrade script for db changes
updated bug_sync code for python-bugzilla >= 0.8


Diffs (updated)
-----

  testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40 
  testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3 
  setup.py e9fc12082a4d16afe93b04d7b96658715403eccc 
  blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1 
  blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b 
  blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a 
  blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73 
  blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8 
  blockerbugs/templates/admin/modify_release.html 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90

  blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842 
  blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f 
  blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f 
  blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93 
  blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4 
  blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b 
  blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12 
  alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION 
  alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/


Testing
-------

I've done several syncs on both sqlite and postgres dbs and clicked around to make
sure that all the templates that _were_ working are still working. Some of the admin pages
still have issues but that is orthogonal to the changes here.

I did an alembic upgrade of the database with no issues.


Thanks,

Tim Flink