This patch involves fixes for tickets in preparation for 0.5.0 release:
* https://fedorahosted.org/autoqa/ticket/314 - Decrease the volume of 'PASSED' email sent to maintainers from bodhi
* https://fedorahosted.org/autoqa/ticket/258 - implement 'make test'
This is a smaller change than the pretty log stuff, so I created a review request in reviewboard based off of a diff from master: - https://fedorahosted.org/reviewboard/r/149/
Otherwise, you can check the diff from master using the commands: $ git fetch $ git diff origin/master..origin/tflink -M
Important changes:
1. Addition of bodhi_update_state: 2. bodhi_utils._is_bodhi_comment_email_needed() 3. Adding a parameter to bodhi_post_testresult() 4. [bodhi_email] section added to autoqa.conf 5. Tests for the code associated with #314
------------------------------------------------------------ | Addition of bodhi_update_state: ------------------------------------------------------------
This object encapsulates information on the state of tests for a given bodhi update. The idea was to encapsulate the logic and make it relatively easy to understand.
------------------------------------------------------------ | bodhi_utils._is_bodhi_comment_email_needed() ------------------------------------------------------------
This was added to bodhi_utils to encapsulate the logic behind whether or not to send an email. _parse_result_from_comment() and _get_bodhi_email_config() were added to support this method
------------------------------------------------------------ | Adding a parameter to bodhi_post_testresult() ------------------------------------------------------------
Since the state of an update's tests depends on the koji tag currently being tested (upgradepath doesn't run on *-updates-testing), the current koji tag became an important part of determining whether or not to send an email.
------------------------------------------------------------ | [bodhi_email] section added to autoqa.conf ------------------------------------------------------------
To support the requirement of changing email behavior without code modifications, more configuration settings were needed. Adding a new section to autoqa.conf was deemed to be the easiest and most self-contained method of getting this done.
------------------------------------------------------------ | Tests for the code associated with #314 ------------------------------------------------------------
This kind of code is a poster child for unit tests, in my mind. Relatively simple code that has subtle changes in logic based on many changing inputs. The tests are written for py.test > 2.0.1 and are in lib/autoqa/tests/
----- Original Message -----
This patch involves fixes for tickets in preparation for 0.5.0 release:
- Decrease the volume of 'PASSED' email sent to maintainers from
bodhi
- implement 'make test'
This is a smaller change than the pretty log stuff, so I created a review request in reviewboard based off of a diff from master:
I've looked at it briefly (and provided some comments), and I'll study it more closely soon.
On 06/07/2011 06:35 AM, Kamil Paral wrote:
This is a smaller change than the pretty log stuff, so I created a review request in reviewboard based off of a diff from master:
I've looked at it briefly (and provided some comments), and I'll study it more closely soon.
Responded to comments, will post new patch soon.
Tim
On 06/07/2011 06:35 AM, Kamil Paral wrote:
This is a smaller change than the pretty log stuff, so I created a review request in reviewboard based off of a diff from master:
I've looked at it briefly (and provided some comments), and I'll study it more closely soon.
Responded to comments, will post new patch soon.
Tim
I've added more responses.
By the way, it seems better to use "Add comment" link in the overview mode or "Reply" link in the diff mode, than to add a brand new comment on the same line. It is then structured in a tree-like conversation, easy to follow.
On 06/08/2011 01:40 AM, Kamil Paral wrote:
On 06/07/2011 06:35 AM, Kamil Paral wrote:
This is a smaller change than the pretty log stuff, so I created a review request in reviewboard based off of a diff from master:
I've looked at it briefly (and provided some comments), and I'll study it more closely soon.
Responded to comments, will post new patch soon.
Tim
I've added more responses.
By the way, it seems better to use "Add comment" link in the overview mode or "Reply" link in the diff mode, than to add a brand new comment on the same line. It is then structured in a tree-like conversation, easy to follow.
I've pushed a new diff up to RB.
I see what you mean about the comments. For some reason, I thought that the two methods were the same. Now I know better :)
Tim
On 06/09/2011 03:47 AM, Kamil Paral wrote:
I've pushed a new diff up to RB.
Reviewed again. The comment section starts to be really long :)
It is getting really long :)
I fixed the issues brought up in the comments and talked to Kamil over IRC. The last fixes were reviewed and the code was deemed ready for merge.
Merged to master: https://fedorahosted.org/autoqa/changeset/613fa26bf144e2c90146344c686cd01eee...
I fixed the issues brought up in the comments and talked to Kamil over IRC. The last fixes were reviewed and the code was deemed ready for merge.
Merged to master: https://fedorahosted.org/autoqa/changeset/613fa26bf144e2c90146344c686cd01eee...
I'll just note that everyone should update their autoqa.conf.
autoqa-devel@lists.fedorahosted.org
-
Kamil Paral -
Tim Flink