[AutoQA] #346: Comments are being mangled before posting to bodhi

[fedora-badges]

#346: Comments are being mangled before posting to bodhi
---------------------+------------------------------------------------------
 Reporter:  tflink   |       Owner:  tflink    
     Type:  defect   |      Status:  new       
 Priority:  blocker  |   Milestone:  Hot issues
Component:  core     |    Keywords:            
---------------------+------------------------------------------------------
 There is a loop in bodhi_utils.py that is overwriting the comment set
 earlier in the bodhi_post_test_result method.

source:lib/autoqa/bodhi_utils.py@3cf90d63c5a77dd1cdbc26f33dbc5ea70b7f1238#L261

The variable names need to be different.

[fedora-badges]

#346: Comments are being mangled before posting to bodhi
---------------------+------------------------------------------------------
 Reporter:  tflink   |        Owner:  tflink    
     Type:  defect   |       Status:  closed    
 Priority:  blocker  |    Milestone:  Hot issues
Component:  core     |   Resolution:  fixed     
 Keywords:           |  
---------------------+------------------------------------------------------
Changes (by tflink):

* status:  new => closed
  * resolution:  => fixed

Comment:

Fixed in master:
  * ef1c0f64f2943ba3851344f99fa3876a4172327b

Fixed in stable:
  * 4ff1f3fee5911c5afff569b6de720dca9093f077

[James Laska]

On Wed, 2011-06-29 at 16:06 +0000, AutoQA wrote:
> #346: Comments are being mangled before posting to bodhi
> ---------------------+------------------------------------------------------
>  Reporter:  tflink   |        Owner:  tflink    
>      Type:  defect   |       Status:  closed    
>  Priority:  blocker  |    Milestone:  Hot issues
> Component:  core     |   Resolution:  fixed     
>  Keywords:           |  
> ---------------------+------------------------------------------------------
> Changes (by tflink):
> status:  new => closed
> resolution:  => fixed
>
> Comment:
>
> Fixed in master:
> ef1c0f64f2943ba3851344f99fa3876a4172327b
>
> Fixed in stable:
> 4ff1f3fee5911c5afff569b6de720dca9093f077

I've applied this change as a hotfix in production.  I'll hold off on
any package rebuilds for another day or so.

Thanks,
James

[fedora-badges]

#346: Comments are being mangled before posting to bodhi
---------------------+------------------------------------------------------
 Reporter:  tflink   |        Owner:  tflink
     Type:  defect   |       Status:  closed
 Priority:  blocker  |    Milestone:  0.5.1 
Component:  core     |   Resolution:  fixed 
 Keywords:           |  
---------------------+------------------------------------------------------
Changes (by kparal):

* milestone:  Hot issues => 0.5.1