On Tue, 2009-11-10 at 11:54 -0500, Kamil Paral wrote:
I'm new to Koji, but I have discussed these things with Daniel
Mach and I think the current koji watcher implementation isn't right.
The problem is that the dist-fxx-updates-candidate tag is valid
for only a while. [...] If we have not detected that new build in the
meantime, we have lost that information and won't know about it
Good catch - yeah, if something got moved to -updates or -testing before
the watcher fired, we'd miss it.
Another (better) solution is to check for all new builds and
filter for only those packages, which have dist-fxx-updates-candidate
tag in *their history* (not necessarily as current tag, which
does current implementation).
Good idea. I've added tag_history() to SimpleKojiClientSession and
modified the watcher to use that instead of list_tags().
Daniel also suggested a few alternative mechanisms for new build
We have plans to use the (planned) kojihub plugin feature to send out
notifications of new builds over the (planned) Fedora Message Bus
Thingy. Eventually all the current watchers should be replaced by simple
listeners on the message bus.