[AutoQA] #343: Bodhi Comment Email Logic is not Detecting Tests

[fedora-badges]

#343: Bodhi Comment Email Logic is not Detecting Tests
--------------------+-------------------------------------------------------
 Reporter:  tflink  |       Owner:  tflink
     Type:  task    |      Status:  new   
 Priority:  major   |   Milestone:  0.5.0 
Component:  core    |    Keywords:        
--------------------+-------------------------------------------------------
 The logic used to determine whether or not to send an email with bodhi
 comments is not working.

 Example of what should have been INCOMPLETE to PASS:
 {{{
 06/13 11:07:13 INFO |      test:0383| Submitting results (log, email,
 bodhi) for: depcheck: PASSED; 1 PASSED for phpMyAdmin-3.4.2-1.fc14
 06/13 11:07:13 INFO |      test:0308| Log created:
 /usr/share/autotest/results/default/depcheck/results/phpMyAdmin-3.4.2-1.f.html
 06/13 11:07:13 INFO |      test:0254| Email not sent: "depcheck: PASSED; 1
 PASSED for phpMyAdmin-3.4.2-1.fc14"
 06/13 11:07:20 INFO |bodhi_upda:0101| Current State of update
 phpMyAdmin-3.4.2-1.fc14 :
 06/13 11:07:20 INFO |bodhi_upda:0101|   {'result': 'PASSED',
'arch':
 'x86_64', 'testname': 'depcheck', 'time':
datetime.datetime(2011, 6, 13,
 14, 52, 1)}
 06/13 11:07:20 INFO |bodhi_upda:0101|
 06/13 11:07:20 INFO |bodhi_upda:0101| Current State of update
 phpMyAdmin-3.4.2-1.fc14 :
 06/13 11:07:20 INFO |bodhi_upda:0101|   {'result': 'PASSED',
'arch':
 'x86_64', 'testname': 'depcheck', 'time':
datetime.datetime(2011, 6, 13,
 14, 52, 1)}
 06/13 11:07:20 INFO |bodhi_upda:0101|   {'result': 'PASSED',
'arch':
 'i386', 'testname': 'depcheck', 'time':
datetime.datetime(2011, 6, 13, 15,
 7, 20, 855416)}
 06/13 11:07:20 INFO |bodhi_upda:0101|
 06/13 11:07:20 INFO |bodhi_util:0390| update state : INCOMPLETE to
 INCOMPLETE
 06/13 11:07:20 INFO |bodhi_util:0275| Bodhi email will NOT be sent
 }}}

 This logic needs to properly detect the tests that have been run.

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/343>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project

[fedora-badges]

#343: Bodhi Comment Email Logic is not Detecting Tests
--------------------+-------------------------------------------------------
 Reporter:  tflink  |        Owner:  tflink
     Type:  task    |       Status:  closed
 Priority:  major   |    Milestone:  0.5.0 
Component:  core    |   Resolution:  fixed 
 Keywords:          |  
--------------------+-------------------------------------------------------
Changes (by tflink):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 I found the bug here and it was due to a bad practice on my part. I wrote
 some string comparisons as

 {{{
 #!python
 if variable is 'value':
     do_something()
 }}}

 Which works in the unit tests due to optimizations in the python vm but
 doesn't work when the objects are not the same id. Either way, code
 shouldn't be written like that.

 Anyhow, this was small enough that I just pushed the fix to master and
 will be updating the test instance shortly.
  * Fix for #343 - 29f6acc289facf31ac3bfac5751d263315519eb2
  * Improving debug logging for bodhi comment emails -
 3cf90d63c5a77dd1cdbc26f33dbc5ea70b7f1238

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/343#comment:1>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project