8:21 p.m.
#306: "Stop That Update!" awarded for update headed to testing
-------------------------------------+-------------------------------------
Reporter: | Owner:
lmacken | Status: new
Type: | Keywords:
Bug report | Has a description: 0
Priority: | Artwork status: None
minor | External requirements:
Has a name: | Triaged (triagers only): 0
0 |
Concept approved (reviewers only): |
0 |
Badge definition status: |
None |
Manually awarded: |
0 |
-------------------------------------+-------------------------------------
Problem:
https://badges.fedoraproject.org/badge/stop-that-update!
The badge description says "You submitted negative feedback on an update
while on its way to the stable repo", however I was just awarded this
badge for giving negative feedback to an update that is on it's way to
*testing*: https://admin.fedoraproject.org/updates/bugwarrior-1.0.1-1.fc21
The rule should probably be fixed, or the badge description get updated.
--
Ticket URL: <https://fedorahosted.org/fedora-badges/ticket/306>
fedora-badges <https://badges.fedoraproject.org>
A place to collect and debate badge ideas for the Fedora Badges app
10:41 p.m.
#306: "Stop That Update!" awarded for update headed to testing
-------------------------------------+-------------------------------------
Reporter: lmacken | Owner:
Type: Bug | Status:
report | new
Priority: minor | Resolution:
Keywords: | Has a name:
Has a description: 0 | 0
Artwork status: None | Concept approved (reviewers only):
External requirements: | 0
Triaged (triagers only): 0 | Badge definition status:
| None
| Manually awarded:
| 0
-------------------------------------+-------------------------------------
Comment (by pnemade):
I guess this happened as there is rule for an update that is in pending
state also
- lambda: msg.get('msg', {}).get('comment',
{}).get('update_status')
== 'pending'
--
Ticket URL: <https://fedorahosted.org/fedora-badges/ticket/306#comment:1>
fedora-badges <https://badges.fedoraproject.org>
A place to collect and debate badge ideas for the Fedora Badges app
2:18 a.m.
#306: "Stop That Update!" awarded for update headed to testing
-------------------------------------+-------------------------------------
Reporter: lmacken | Owner:
Type: Bug | Status:
report | new
Priority: minor | Resolution:
Keywords: | Has a name:
Has a description: 0 | 0
Artwork status: None | Concept approved (reviewers only):
External requirements: | 0
Triaged (triagers only): 0 | Badge definition status:
| None
| Manually awarded:
| 0
-------------------------------------+-------------------------------------
Comment (by ralph):
For reference, here's the message the incorrectly awarded the badge:
https://apps.fedoraproject.org/datagrepper/id?id=2014-e6332f0f-2d75-4a46
-8bfe-d486623b6c93&is_raw=true&size=extra-large
And, here's the rule that awards the badge
https://git.fedorahosted.org/cgit/badges.git/tree/rules/stop-that-
update.yml
We could probably just add this to the trigger:
{{{
lambda: msg.get('msg', {}).get('comment',
{}).get('update_request') ==
'stable'
}}}
--
Ticket URL: <https://fedorahosted.org/fedora-badges/ticket/306#comment:2>
fedora-badges <https://badges.fedoraproject.org>
A place to collect and debate badge ideas for the Fedora Badges app
12:26 p.m.
#306: "Stop That Update!" awarded for update headed to testing
-------------------------------------+-------------------------------------
Reporter: lmacken | Owner:
Type: Bug | Status:
report | new
Priority: minor | Resolution:
Keywords: | Has a name:
Has a description: 0 | 0
Artwork status: None | Concept approved (reviewers only):
External requirements: | 0
Triaged (triagers only): 0 | Badge definition status:
| None
| Manually awarded:
| 0
-------------------------------------+-------------------------------------
Comment (by lmacken):
Replying to [comment:2 ralph]:
We could probably just add this to the trigger:
{{{
lambda: msg.get('msg', {}).get('comment',
{}).get('update_request') ==
'stable'
}}}
Yeah, I think this'll do it. +1
--
Ticket URL: <https://fedorahosted.org/fedora-badges/ticket/306#comment:3>
fedora-badges <https://badges.fedoraproject.org>
A place to collect and debate badge ideas for the Fedora Badges app
2:23 p.m.
#306: "Stop That Update!" awarded for update headed to testing
-------------------------------------+-------------------------------------
Reporter: lmacken | Owner:
Type: Bug | Status:
report | new
Priority: minor | Resolution:
Keywords: | Has a name:
Has a description: 0 | 0
Artwork status: None | Concept approved (reviewers only):
External requirements: | 0
Triaged (triagers only): 0 | Badge definition status:
| None
| Manually awarded:
| 0
-------------------------------------+-------------------------------------
Comment (by ralph):
Patched here:
https://git.fedorahosted.org/cgit/badges.git/commit/?id=4c9b6dc393c505e18...
--
Ticket URL: <https://fedorahosted.org/fedora-badges/ticket/306#comment:4>
fedora-badges <https://badges.fedoraproject.org>
A place to collect and debate badge ideas for the Fedora Badges app
2:23 p.m.
#306: "Stop That Update!" awarded for update headed to testing
-------------------------------------+-------------------------------------
Reporter: lmacken | Owner:
Type: Bug | Status:
report | closed
Priority: minor | Resolution:
Keywords: | pushed
Has a description: 0 | Has a name:
Artwork status: None | 0
External requirements: | Concept approved (reviewers only):
Triaged (triagers only): 0 | 0
| Badge definition status:
| None
| Manually awarded:
| 0
-------------------------------------+-------------------------------------
Changes (by ralph):
* resolution: => pushed
* status: new => closed
--
Ticket URL: <https://fedorahosted.org/fedora-badges/ticket/306#comment:5>
fedora-badges <https://badges.fedoraproject.org>
A place to collect and debate badge ideas for the Fedora Badges app
3493
days inactive
3496
days old
badges@lists.fedoraproject.org
5 comments
1 participants
participants (1)
-
fedora-badges