#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: | Owner: robyduck | Status: new Type: | Keywords: New badge idea | Has a description: 1 Priority: | Artwork status: None minor | External requirements: Has a name: | Triaged (triagers only): 0 1 | Concept approved (reviewers only): | 0 | Badge definition status: | None | Manually awarded: | 0 | -------------------------------------+------------------------------------- Badge description (like "You added a co-maintainer to a package. BFF!"): "Long life to pagure"
This badge, which can be a series, should be awarded for committing to a pagure repository. We are incouraging people to switch from fedorahosted to pagure and we could give them some badges for it.
Badges could be awarded with the same concept as for pushing to a Fedora package repository, for 1-10-50-250-500-1000 commits.
I will think about an artwork concept too, but the design could contain a panda badger with a sweet pagure under his arm, for example.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | Status: idea | new Priority: minor | Resolution: Keywords: | Has a name: Has a description: 1 | 1 Artwork status: None | Concept approved (reviewers only): External requirements: | 0 Triaged (triagers only): 0 | Badge definition status: | None | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
It's an attempt, if we want to do a series we should probably think about something else. Maybe a panda in a boat, and at the end the boat is full of pagures :D [[Image(pagure-1.png)]]
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | Status: idea | new Priority: minor | Resolution: Keywords: | Has a name: Has a description: 1 | 1 Artwork status: None | Concept approved (reviewers only): External requirements: | 0 Triaged (triagers only): 0 | Badge definition status: | None | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by ralph):
Random idea: Have the panda's face peeking out from the hermit crab shell?
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | Status: idea | new Priority: minor | Resolution: Keywords: | Has a name: Has a description: 1 | 1 Artwork status: None | Concept approved (reviewers only): External requirements: | 0 Triaged (triagers only): 0 | Badge definition status: | None | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
Nice idea. Something like this? [[Image(pagure-1b.png)]]
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | Status: idea | new Priority: minor | Resolution: Keywords: | Has a name: Has a description: 1 | 1 Artwork status: Proposed | Concept approved (reviewers only): External requirements: | 0 Triaged (triagers only): 0 | Badge definition status: | None | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by robyduck):
* has_artwork: None => Proposed
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | Status: idea | new Priority: minor | Resolution: Keywords: | Has a name: Has a description: 1 | 1 Artwork status: Proposed | Concept approved (reviewers only): External requirements: | 0 Triaged (triagers only): 0 | Badge definition status: | None | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
I made a series for pagure commits. Thoughts? [[Image(1.png)]] [[Image(10.png)]] [[Image(50.png)]] [[Image(150.png)]] [[Image(500.png)]] [[Image(1000.png)]]
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | Status: idea | new Priority: minor | Resolution: Keywords: | Has a name: Has a description: 1 | 1 Artwork status: Proposed | Concept approved (reviewers only): External requirements: | 0 Triaged (triagers only): 0 | Badge definition status: | None | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by churchyard):
robyduck, you rock
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 0 | 0 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by robyduck):
* owner: => robyduck * has_complete_yaml: None => Full, needs review * status: new => assigned
Comment:
Uploading the yml file for the first badge, just to adapt for the others I think. Needs a review!
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by jflory7):
* cc: riecatnor, mleonova (added) * triaged: 0 => 1 * concept_review_passed: 0 => 1
Comment:
Marking ticket as triaged, concept looks good to me! CCing Design Team members for artwork review / feedback.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by mleonova):
Hey! Fun badges! I think commit badges should have pink background (see style guide). These look great to me, awesome job, robyduck!
*why is 10 a python? ;)
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
I chose the same background as for packaging commit badges. Should I change them all?
And I decided to make appear also a nice python because Pagure is written with Flask -> Python, that's the main reason. The other is...it looks so nice to have the pagure on the back of our little python :D
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by mleonova):
I like the python, yeah =) What, this one? Let's change just one for starters and see how it looks, but we really do want to be consistent. [[Image(https://badges.fedoraproject.org/pngs/you-can-call-me- patches-01.png)]]
Replying to [comment:10 robyduck]:
I chose the same background as for packaging commit badges. Should I
change them all?
And I decided to make appear also a nice python because Pagure is
written with Flask -> Python, that's the main reason. The other is...it looks so nice to have the pagure on the back of our little python :D
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
Personally I like it less, and we need to make the pagure with a white line inside (need help). Here is the pink one. [[Image(1_pink.png)]]
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by duffy):
I agree with Maria that we should be consistent with the backgrounds, otherwise these badges look great. Eg for the background spec it's on this page of the badge styleguide:
https://fedorahosted.org/fedora- badges/attachment/wiki/DesignResources/styleguide_3.c.png
I can help with the pagure transparency, one sec and I'll upload a version that won't do that.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Proposed | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
Thanks mizmo, nice solution. Here are the updated badges: [[Image(1_pink-filledshell.png)]] [[Image(10_pink-filledshell.png)]] [[Image(50_pink-filledshell.png)]] [[Image(150_pink-filledshell.png)]] [[Image(500_pink-filledshell.png)]] [[Image(1000_pink-filledshell.png)]]
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by duffy):
* has_artwork: Proposed => Approved (design team members only)
Comment:
Robyduck: perfecto! Setting artwork_approved.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by jflory7):
* cc: nb, sysadmin-badges-members@… (added)
Comment:
Seems like this badge just needs to evaluated by a sysadmin-badges member to ensure the YAML file is all set. Artwork is a go. Anyone think they can review this ticket?
I can look at it today.
-Zach #aikidouke On Tue, Jul 5, 2016 at 2:10 PM fedora-badges trac@fedorahosted.org wrote:
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by jflory7):
- cc: nb, sysadmin-badges-members@… (added)
Comment:
Seems like this badge just needs to evaluated by a sysadmin-badges member to ensure the YAML file is all set. Artwork is a go. Anyone think they can review this ticket?
-- Ticket URL: https://fedorahosted.org/fedora-badges/ticket/434#comment:16 fedora-badges https://badges.fedoraproject.org A place to collect and debate badge ideas for the Fedora Badges app
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by aikidouke):
Hi guys - First time reviewing a badge, so if I am outrageously wrong, nb or ralph can correct me.
- I think we need a recipient line in the .yml file - Created separate yml files for each level - Each separate yml file would need an updated description and image url
If any of that is what I need to do, I will happily follow up.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by jflory7):
Thanks for reviewing this ticket, aikidouke! I went ahead and organized all of the PNGs and SVGs under a uniform naming scheme (`pagure-long- life-*.*`) for all files. I updated all of the YAML files to be correct and current for names, descriptions, image file name locations, and commit counts. I also generated STLs for all of the Pagure badges, which will let us print these with 3D printers, given the chance. :)
For simplicity, you can merge this [https://fedorahosted.org/fedora- badges/attachment/ticket/434/0001-Add-Long-Life-to-Pagure-series-PNG-YML- SVG-STL.patch patch] in, which will move all of the files for this badge in.
Let me know if anything else is needed, thanks!
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by aikidouke):
I have pushed the badges and rules to production. Can someone clarify the badge names for me?
Should they be;
"Long Life to Pagure (Pagure I)"
OR
"Pagure I"
and so on for each in the series?
Thanks!
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by jflory7):
I think the name for the badges should be as they are pushed already, "Long Life to Pagure (Pagure I)". This is how other series badges are formatted so I believe this is the best way to name them.
I noticed that these badges are missing tags, so they're showing up as uncategorized. They should probably receive two: "development" and "pagure". This should sort them all correctly in Tahrir.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by aikidouke):
Hello - Badges have been pushed and [tagged](https://badges.fedoraproject.org/tags/pagure/any) with development, pagure. I have not had a chance to test yet.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by churchyard):
I've just pushed some commits and nothing. The porblem seems to be, that no fedmsgs are emitted
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by sayanchowdhury):
fedmsg are emitted. Looks like wrong yml file. It's throwing a KeyError: 'msg.commit.username'
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by churchyard):
Yet I don't see any https://apps.fedoraproject.org/datagrepper/raw?user=churchyard
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by robyduck):
Yeah, I think pagure doesn't emit the username, the yml needs to catch the mail address for now. Not sure if pingou is planning to add the username in fedmsg in the next releases, but for now I guess the only way is through the email.
There is just one problem, pagure permits to register with several mail addresses, so if you want match the address with the nick, and use the one in FAS, people who used another address on pagure won't get the badge.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by churchyard):
Pagure issue: https://pagure.io/pagure/issue/1140
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by churchyard):
So, here's the thing:
1) my issue of no fedmsg was solved by opt-in in repo settings
2) the username of the committer (or I guess pusher) is in in msg.user.name
3) count of the commits is in msg.total_commits (and that somehow needs to be accumulated if we count commits and not pushes)
See example message here https://apps.fedoraproject.org/datagrepper/id?id=2016-10c66966-ee17-4511-929... =extra-large
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | assigned Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by gnokii):
isnt that pushed?
https://badges.fedoraproject.org/badge/long-life-to-pagure-pagure-i https://badges.fedoraproject.org/badge/long-life-to-pagure-pagure-ii https://badges.fedoraproject.org/badge/long-life-to-pagure-pagure-iii https://badges.fedoraproject.org/badge/long-life-to-pagure-pagure-iv https://badges.fedoraproject.org/badge/long-life-to-pagure-pagure-v https://badges.fedoraproject.org/badge/long-life-to-pagure-pagure-vi
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | closed Keywords: | Resolution: Has a description: 1 | pushed Artwork status: Approved | Has a name: (design team members only) | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by gnokii):
* status: assigned => closed * resolution: => pushed
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | closed Keywords: | Resolution: Has a description: 1 | pushed Artwork status: Approved | Has a name: (design team members only) | 1 External requirements: | Concept approved (reviewers only): Triaged (triagers only): 1 | 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by sayanchowdhury):
Yes, this has been pushed. But the rules are not proper therefore the badges are not awarded to anyone. IMO the ticket should be open till the correct rules are not pushed.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | reopened Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by churchyard):
* status: closed => reopened * resolution: pushed =>
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: minor | reopened Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by lsedlar):
The message format from Pagure has changed in the past I believe. I have attached a patch that may fix the problem and only works with the current format.
There are three places in the message with some name: * {{{msg.agent}}} is the person who pushed the commits * {{{msg.repo.user.name}}} is owner of the repo that was pushed to * {{{msg.authors[].name}}} is a list of people who wrote the pushed commits
My patch is using the first of these, as there there is no way to map individual authors to commits they wrote. It will also accumulate the number in msg.total_commits.
The big question is if this is the right approach: if the project is using pull requests from individual forks, people will have to enable the fedmsg hook for their forks (because merging via web interface does not send this kind of message). If they do, they may get badges for pushes that never make it into the main repo.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: major | reopened Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+------------------------------------- Changes (by jflory7):
* cc: pingou, ralph, puiterwijk (added) * priority: minor => major
Comment:
I'm CCing some other stakeholders in Badges / Fedora Infra for comments and thoughts on the above rules file. If this is the way we want to go, I'd be happy to push this out (assuming there's no special steps required for adding / updating a rule for a pre-existing badge).
Also raising the priority to major since this is a badge we have pushed, but is not current working.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: major | reopened Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by sayanchowdhury):
As far my discussion with pingou, the plan was to adjust the fedmsg-hook itself to include the number of commits person.
#434: Contributing to a pagure repository -------------------------------------+------------------------------------- Reporter: robyduck | Owner: Type: New badge | robyduck idea | Status: Priority: major | reopened Keywords: | Resolution: Has a description: 1 | Has a name: Artwork status: Approved | 1 (design team members only) | Concept approved (reviewers only): External requirements: | 1 Triaged (triagers only): 1 | Badge definition status: | Full, needs review | Manually awarded: | 0 -------------------------------------+-------------------------------------
Comment (by sayanchowdhury):
Replying to [comment:32 lsedlar]:
The message format from Pagure has changed in the past I believe. I have
attached a patch that may fix the problem and only works with the current format.
There are three places in the message with some name:
- {{{msg.agent}}} is the person who pushed the commits
- {{{msg.repo.user.name}}} is owner of the repo that was pushed to
- {{{msg.authors[].name}}} is a list of people who wrote the pushed
commits
My patch is using the first of these, as there there is no way to map
individual authors to commits they wrote. It will also accumulate the number in msg.total_commits.
Yes, the older format of the Pagure fedmsg message included the number of commits per author. If the {{{msg.agent}}} is given the given the badge then it will only be the admins who will get the badge. So, I think its worth waiting for the hook or if the hook takes time then we just push this patch for now. Thoughts?
badges@lists.fedoraproject.org
-
fedora-badges -
Zach Villers