Task /distribution/reservesys is broken on Fedora21

[Jirka Hladky]

Hello,

extendtesttime.sh does not work on Fedora21 Server:

[root@karkulka-02 tests]# extendtesttime.sh 48
Extending reservation time 48
ERROR: 2 args provided

Usage:
     rhts-test-checkin <lab_server> <hostname> <jobid> <test> <killtime> 
<testid>

root: rhts-test-checkin  karkulka-02.lab.eng.brq.redhat.com   48h

How to reproduce?

Privison in Beaker server with "Fedora-Server-21_Beta Server x86_64". 
After installation, login on the server and try to run extendtesttime.sh

Bellow is an example XML generated by Beaker "Provision" command.

Thanks
Jirka

<job retention_tag="scratch">
     <whiteboard>
         Provision Fedora-Server-21_Beta Server x86_64
     </whiteboard>
     <recipeSet priority="High">
         <recipe kernel_options="console=tty0 console=ttyS1,115200n81 
ksdevice=C8:1F:66:F4:15:C4 rdblacklist=mtip32xx" kernel_options_post="" 
ks_meta="docker_package=docker-io end=%end grubport=0x02f8 
has_autopart_type=True has_chrony=True has_leavebootorder=True 
has_repo_cost=True has_systemd=True has_unsupported_hardware=True" 
role="RECIPE_MEMBERS" whiteboard="">
             <autopick random="false"/>
             <watchdog panic="ignore"/>
             <packages/>
             <ks_appends/>
             <repos/>
             <distroRequires>
                 <and>
                     <distro_family op="=" value="Fedora21"/>
                     <distro_variant op="=" value="Server"/>
                     <distro_name op="=" value="Fedora-Server-21_Beta"/>
                     <distro_arch op="=" value="x86_64"/>
                 </and>
             </distroRequires>
             <hostRequires>
                 <and>
                     <hostname op="=" 
value="karkulka-02.lab.eng.brq.redhat.com"/>
                     <system_type op="=" value="Machine"/>
                 </and>
             </hostRequires>
             <partitions/>
             <task name="/distribution/install" role="STANDALONE"/>
             <task name="/distribution/reservesys" role="STANDALONE">
                 <params>
                     <param name="RESERVETIME" value="86400"/>
                 </params>
             </task>
         </recipe>
     </recipeSet>
</job>

[Amit Saha]

----- Original Message -----
> From: "Jirka Hladky" 
> To: "Beaker Developers" , "Dan Callaghan" 
> Cc: "Kamil Kolakowski" 
> Sent: Monday, November 24, 2014 9:25:33 PM
> Subject: [Beaker-devel] Task /distribution/reservesys is broken on Fedora21
>
> Hello,
>
> extendtesttime.sh does not work on Fedora21 Server:
>
> [root@karkulka-02 tests]# extendtesttime.sh 48
> Extending reservation time 48
> ERROR: 2 args provided
>
> Usage:
>      rhts-test-checkin <lab_server> <hostname> <jobid> <test> <killtime>
>
> <testid>
>
> root: rhts-test-checkin  karkulka-02.lab.eng.brq.redhat.com   48h

It looks like the extendtestime.sh script wasn't created correctly by the reservesys
task. These last few lines are relevant:

export RESULT_SERVER=$RESULT_SERVER
export HOSTNAME=$HOSTNAME
export JOBID=$JOBID
export TEST=$TEST
export TESTID=$TESTID
rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME $TESTID
logger -s "rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME $TESTID"

So, looks like the environment variables above were not correctly available to your task.

FWIW, I could not reproduce it on beaker.engineering with Fedora-Server-21_Beta Server x86_64.
Is there a job ID you have?

Best,
Amit.

[Dan Callaghan]

Excerpts from Amit Saha's message of 2014-11-25 12:45 +10:00:
> > Hello,
> >
> > extendtesttime.sh does not work on Fedora21 Server:
> >
> > [root@karkulka-02 tests]# extendtesttime.sh 48
> > Extending reservation time 48
> > ERROR: 2 args provided
> >
> > Usage:
> >      rhts-test-checkin <lab_server> <hostname> <jobid> <test> <killtime>
> >
> > <testid>
> >
> > root: rhts-test-checkin  karkulka-02.lab.eng.brq.redhat.com   48h
>
> It looks like the extendtestime.sh script wasn't created correctly by 
> the reservesys task. These last few lines are relevant:
>
> export RESULT_SERVER=$RESULT_SERVER
> export HOSTNAME=$HOSTNAME
> export JOBID=$JOBID
> export TEST=$TEST
> export TESTID=$TESTID
> rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME $TESTID
> logger -s "rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME $TESTID"
>
> So, looks like the environment variables above were not correctly 
> available to your task.

Jirka, are you using a harness other than beah?

[Jirka Hladky]

On 11/25/2014 04:48 AM, Dan Callaghan wrote:
> Excerpts from Amit Saha's message of 2014-11-25 12:45 +10:00:
> > > Hello,
> > >
> > > extendtesttime.sh does not work on Fedora21 Server:
> > >
> > > [root@karkulka-02 tests]# extendtesttime.sh 48
> > > Extending reservation time 48
> > > ERROR: 2 args provided
> > >
> > > Usage:
> > >       rhts-test-checkin <lab_server> <hostname> <jobid> <test> <killtime>
> > >
> > > <testid>
> > >
> > > root: rhts-test-checkin  karkulka-02.lab.eng.brq.redhat.com   48h
> >
> > It looks like the extendtestime.sh script wasn't created correctly by
> > the reservesys task. These last few lines are relevant:
> >
> > export RESULT_SERVER=$RESULT_SERVER
> > export HOSTNAME=$HOSTNAME
> > export JOBID=$JOBID
> > export TEST=$TEST
> > export TESTID=$TESTID
> > rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME $TESTID
> > logger -s "rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME $TESTID"
> >
> > So, looks like the environment variables above were not correctly
> > available to your task.
>
> Jirka, are you using a harness other than beah?

Hi all,

I have used "Provision" functionality in Beaker.

1) Pick up a free server in Beaker
2) Click on Provision
3)Select  Fedora21 Beta Server
4)Click on Schedule Provision

Generated XML is bellow this message.

Please check this job in Beaker:
https://beaker.engineering.redhat.com/jobs/808833

Thanks
Jirka

<job retention_tag="scratch">
     <whiteboard>
         Provision Fedora-Server-21_Beta Server x86_64
     </whiteboard>
     <recipeSet priority="High">
         <recipe kernel_options="console=tty0 console=ttyS1,115200n81 
ksdevice=C8:1F:66:F4:15:C4 rdblacklist=mtip32xx" kernel_options_post="" 
ks_meta="docker_package=docker-io end=%end grubport=0x02f8 
has_autopart_type=True has_chrony=True has_leavebootorder=True 
has_repo_cost=True has_systemd=True has_unsupported_hardware=True" 
role="RECIPE_MEMBERS" whiteboard="">
             <autopick random="false"/>
             <watchdog panic="ignore"/>
             <packages/>
             <ks_appends/>
             <repos/>
             <distroRequires>
                 <and>
                     <distro_family op="=" value="Fedora21"/>
                     <distro_variant op="=" value="Server"/>
                     <distro_name op="=" value="Fedora-Server-21_Beta"/>
                     <distro_arch op="=" value="x86_64"/>
                 </and>
             </distroRequires>
             <hostRequires>
                 <and>
                     <hostname op="=" 
value="karkulka-02.lab.eng.brq.redhat.com"/>
                     <system_type op="=" value="Machine"/>
                 </and>
             </hostRequires>
             <partitions/>
             <task name="/distribution/install" role="STANDALONE"/>
             <task name="/distribution/reservesys" role="STANDALONE">
                 <params>
                     <param name="RESERVETIME" value="86400"/>
                 </params>
             </task>
         </recipe>
     </recipeSet>
</job>

[Amit Saha]

Hi Jirka,

----- Original Message -----
> From: "Jirka Hladky" 
> To: "Dan Callaghan" 
> Cc: "Kamil Kolakowski" , "Beaker development" 
> Sent: Wednesday, November 26, 2014 8:21:54 PM
> Subject: Re: [Beaker-devel] Task /distribution/reservesys is broken on	Fedora21
>
> On 11/25/2014 04:48 AM, Dan Callaghan wrote:
> > Excerpts from Amit Saha's message of 2014-11-25 12:45 +10:00:
> > > > Hello,
> > > >
> > > > extendtesttime.sh does not work on Fedora21 Server:
> > > >
> > > > [root@karkulka-02 tests]# extendtesttime.sh 48
> > > > Extending reservation time 48
> > > > ERROR: 2 args provided
> > > >
> > > > Usage:
> > > >       rhts-test-checkin <lab_server> <hostname> <jobid> <test> <killtime>
> > > >
> > > > <testid>
> > > >
> > > > root: rhts-test-checkin  karkulka-02.lab.eng.brq.redhat.com   48h
> > >
> > > It looks like the extendtestime.sh script wasn't created correctly by
> > > the reservesys task. These last few lines are relevant:
> > >
> > > export RESULT_SERVER=$RESULT_SERVER
> > > export HOSTNAME=$HOSTNAME
> > > export JOBID=$JOBID
> > > export TEST=$TEST
> > > export TESTID=$TESTID
> > > rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST $EXTRESTIME
> > > $TESTID
> > > logger -s "rhts-test-checkin $RESULT_SERVER $HOSTNAME $JOBID $TEST
> > > $EXTRESTIME $TESTID"
> > >
> > > So, looks like the environment variables above were not correctly
> > > available to your task.
> >
> > Jirka, are you using a harness other than beah?
>
> Hi all,
>
> I have used "Provision" functionality in Beaker.
> Pick up a free server in Beaker
> Click on Provision
>
> 3)Select  Fedora21 Beta Server
> 4)Click on Schedule Provision

I did exactly this, and sorry, I can't still reproduce it:

# rpm -q beah
beah-0.7.7-1.fc21.noarch

# extendtesttime.sh 48
Extending reservation time 48
root: rhts-test-checkin [::1]:7083 cisco-b200m3-01.rhts.eng.bos.redhat.com 811874 /distribution/reservesys 48h 26225415

Can you please copy/paste your
/usr/bin/extendtesttime.sh script next time you see this? Please make sure to modify 
the internal host names  in the script.