Excerpts from Dan Callaghan's message of 2014-02-27 07:52:42 +1000:
Excerpts from Mike Gahagan's message of 2014-02-27 07:32:43 +1000:
On 02/26/2014 01:46 AM, Nick Coghlan wrote:
The other thing I noticed in clicking through the workflow on the system with loans enabled is that *returning* the system wasn't very smooth:
- Click Borrow in right hand quick info
- Click Take
- Click Return
- Click Take accidentally(!)
- Click Return again
- Find & Click "Loan" in the tab navigation
- Click Return Loan
So, I'm thinking it may be appropriate to have a split button there in a couple of cases:
I noticed this too... no simple and obvious way to return the loan... which leads us to a lack of systems because people forget to return them, especially when the "take" button changes to "return" it leads me to believe that if I'm done with the box, I can just click "Return" and move on without realizing I didn't actually return the loan. So no better/worse than the old design in this respect, since in the old one it wasn't obvious I had to return the loan either unless I happened to click on my userid.
Yes I agree, we need an equally obvious way to return the loan.
Unfortunately Bootstrap 2 doesn't have block-level button groups, which is what we would need here to make it look right. They were added in Bootstrap 3, I will look into backporting those bits.
I wrote a patch to show both Take and Return Loan when they are both permitted.
Now that we are allowing Take of Automated systems that are loaned, that means it's (almost) always going to show both Take and Return Loan, when a system is loaned.
http://gerrit.beaker-project.org/2869
This does kind of defeat the stated design of the quick info boxes which was for each one to have "a single button offering the most common action", but oh well...