Re: [bodhi] [PATCH] incite bug reporters to post feedback
by François Cami
Hello Luke, test@, bodhi@,
On Sun, Dec 5, 2010 at 6:22 AM, Kevin Fenzi <kevin(a)scrye.com> wrote:
> On Sat, 4 Dec 2010 17:56:42 +0100
> François Cami <fdc-lists(a)fcami.net> wrote:
>
>> The following patch tentatively changes the message bodhi posts to
>> bugzilla when a build is tagged as an update candidate to make clear
>> that we expect bug reporters to post their feedbacks on updates in the
>> bodhi instance.
>> Please review the message - I am sure someone can make it better.
>
> See also:
>
> https://fedorahosted.org/fedora-infrastructure/ticket/701
I have attached a refined version of the patch to this email, that
hopefully takes into account all the feedboack from Monday's QA
meeting.
I don't think this is a perfect solution and it clearly does not solve
all the issues listed in the afore-mentioned ticket but should still
incite bug reporters to post feedback / karma.
Cheers
François
13 years, 3 months
2 commits - bodhi/tools
by Luke Macken
bodhi/tools/dev_init.py | 2 ++
bodhi/tools/init.py | 2 ++
bodhi/tools/metrics.py | 2 ++
bodhi/tools/pickledb.py | 2 ++
4 files changed, 8 insertions(+)
New commits:
commit 1c769bcf55c9daaf09603e8fceb897578ce02302
Author: Luke Macken <lmacken(a)redhat.com>
Date: Tue Dec 14 15:50:15 2010 -0500
Some more __requires__/setuptools hacks
diff --git a/bodhi/tools/metrics.py b/bodhi/tools/metrics.py
index 34fa9c3..5fe6342 100755
--- a/bodhi/tools/metrics.py
+++ b/bodhi/tools/metrics.py
@@ -5,6 +5,8 @@ A tool for generating statistics for each release.
.. moduleauthor:: Luke Macken <lmacken(a)redhat.com>
"""
+__requires__ = 'bodhi'
+
from operator import itemgetter
from sqlobject import AND
from datetime import timedelta
commit cb26670a766d6acaddbbd0aeac824db02d6e0fc8
Author: Luke Macken <lmacken(a)redhat.com>
Date: Fri Dec 10 16:04:48 2010 -0500
Add more __requires__ pkg_resources hacks to our scripts
diff --git a/bodhi/tools/dev_init.py b/bodhi/tools/dev_init.py
index b98dad8..573a9c9 100755
--- a/bodhi/tools/dev_init.py
+++ b/bodhi/tools/dev_init.py
@@ -8,6 +8,8 @@ This script will populate your bodhi instance with sample releases, updates,
comments, etc.
"""
+__requires__ = 'bodhi'
+
from turbogears.database import PackageHub
from bodhi.util import load_config
from bodhi.exceptions import DuplicateEntryError
diff --git a/bodhi/tools/init.py b/bodhi/tools/init.py
index 32797fd..aacf47b 100755
--- a/bodhi/tools/init.py
+++ b/bodhi/tools/init.py
@@ -17,6 +17,8 @@
""" Bodhi Initialization """
+__requires__ = 'bodhi'
+
from os.path import isfile
from turbogears import config, update_config
diff --git a/bodhi/tools/pickledb.py b/bodhi/tools/pickledb.py
index cdc1dba..9f10a6a 100755
--- a/bodhi/tools/pickledb.py
+++ b/bodhi/tools/pickledb.py
@@ -19,6 +19,8 @@ This script pickles all updates/bugs/cves/comments and writes it out to disk
in the format of bodhi-pickledb-YYYYMMDD.HHMM
"""
+__requires__ = 'bodhi'
+
import sys
import time
import cPickle as pickle
13 years, 4 months
bodhi/tools
by Luke Macken
bodhi/tools/client.py | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
New commits:
commit e23cd5bac8a3ec53743829a5ee4ce377575e72e9
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Dec 9 17:44:23 2010 -0500
Make `bodhi --push-type` work for updates going to testing as well
diff --git a/bodhi/tools/client.py b/bodhi/tools/client.py
index 66eb5d3..00880d7 100755
--- a/bodhi/tools/client.py
+++ b/bodhi/tools/client.py
@@ -238,16 +238,9 @@ def main():
if opts.push_type:
fupdates = []
for ptype in opts.push_type:
- # Filter all testing updates into the set, since
- # we only want push_type to apply to stable.
- fdata = filter(lambda x: x['type'] == ptype and x['request'] == 'stable',
- data['updates'])
+ fdata = filter(lambda x: x['type'] == ptype, data['updates'])
fupdates += fdata
- fdata = filter(lambda x: x['request'] == 'testing',
- data['updates'])
- fupdates += fdata
data['updates'] = fupdates
-
if opts.push_request:
fupdates = []
for req in opts.push_request:
13 years, 4 months
bodhi/admin.py
by Luke Macken
bodhi/admin.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit f2eeeaefbcd9faa09fb3d12dd44f52f40ea29f0b
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Dec 9 16:06:42 2010 -0500
Don't require security update approval when pushing security updates
diff --git a/bodhi/admin.py b/bodhi/admin.py
index ef52989..e820ece 100644
--- a/bodhi/admin.py
+++ b/bodhi/admin.py
@@ -123,8 +123,9 @@ class AdminController(Controller, SecureResource):
# PackageUpdate.select(
# PackageUpdate.q.request != None))
for update in requests:
- if update.type == 'security' and not update.approved:
- continue
+ # Disable security approval requirement
+ #if update.type == 'security' and not update.approved:
+ # continue
updates.append(update)
return dict(updates=updates, resume=resume)
13 years, 4 months
Bodhi v2.0 feature draft
by Luke Macken
Hey all,
I just threw all of my bodhi v2.0 notes on to the wiki:
https://fedoraproject.org/wiki/Bodhi/2.0
Please feel free to chime in with your questions, comments, ideas,
criticism, etc.
As for a timeline/ETA, that will be difficult to estimate. The model
and unit tests have been ported from TG1 to TG2, and the controllers,
templates, and widgets still need to be ported. If you're interested in
helping out, please let me know.
Cheers,
luke
13 years, 4 months
[PATCH] incite bug reporters to post feedback
by François Cami
Hi bodhi@, test@,
The following patch tentatively changes the message bodhi posts to
bugzilla when a build is tagged as an update candidate to make clear
that we expect bug reporters to post their feedbacks on updates in the
bodhi instance.
Please review the message - I am sure someone can make it better.
Caveat emptor: I do not have a bodhi+koji+bz instance, so this is
completely untested.
Signed-Off-By: François Cami <fcami(a)fedoraproject.org>
Patch also attached because I'm pretty sure the inline version will get mangled.
diff --git a/bodhi/controllers.py b/bodhi/controllers.py
index f323291..3c55512 100644
--- a/bodhi/controllers.py
+++ b/bodhi/controllers.py
@@ -971,9 +971,12 @@ class Root(controllers.RootController):
log.debug("Updating newly added bug: %s" % bug)
try:
Bugzilla.byBz_id(bug).add_comment(update,
- "%s has been submitted as an update
for %s.\n%s" %
- (update.title, release.long_name,
- config.get('base_address') +
tg_url(update.get_url())))
+ "%s has been submitted as an update
for %s and "
+ "will soon be available in the
updates-testing "
+ "repository. Please comment on your
experience at:\n"
+ "%s" % (
+ update.title, release.long_name,
+ config.get('base_address') +
tg_url(update.get_url())))
except SQLObjectNotFound:
log.debug('Bug #%d not found in our
database' % bug)
@@ -992,9 +995,12 @@ class Root(controllers.RootController):
# Comment on all bugs
for bug in update.bugs:
bug.add_comment(update,
- "%s has been submitted as an update for %s.\n%s" %
- (update.title, release.long_name,
- config.get('base_address') +
tg_url(update.get_url())))
+ "%s has been submitted as an update for %s and "
+ "will soon be available in the updates-testing "
+ "repository. Please comment on your experience at:\n"
+ "%s" % (
+ update.title, release.long_name,
+ config.get('base_address') +
tg_url(update.get_url())))
# If a request is specified, make it. By default we're submitting
# new updates directly into testing
--
1.7.3.2
13 years, 4 months
