[PATCH] Read some defaults from an optional config file
by Pat Riehecky
From: Pat Riehecky <riehecky(a)fnal.gov>
Pungi's highly customizable behavior lends itself to some fairly long
execution lines. The attached patch will allow setting some defaults
in a ~/.pungirc while still allowing the end user to override them
on the command line.
I hope to eventually expand this to cover more of the pungi options.
But first things first, are there any objections to this patch?
Pat Riehecky (1):
Allow for setting some defaults via a .pungirc
src/pypungi/config.py | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
9 years
pungi for RHEL 7
by Connie Sieh
The pungi in git is clearly for Fedora. It can however be used for RHEL 7
but a few "patches" are needed for it to work.
How would the patches best be put in pungi? There can be individual
command line options added that enable/disable features. A example of
this is there is no hfs support in RHEL 7 so a "nomacboot" command line
option could be added to disable this. Another option is a single "rhel7"
option that could cover all the rhel 7 patches. Which way would be best?
--
Connie J. Sieh
Computing Services Specialist III
Fermi National Accelerator Laboratory
630 840 8531 office
http://www.fnal.gov
csieh(a)fnal.gov
9 years, 3 months
[PATCH] Compress docker images with xz
by Josh Boyer
Imagefactory supports gzip, bzip2, and xz compression formats. Upstream
Docker prefers xz, so switch to using that.
---
builder/kojid | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builder/kojid b/builder/kojid
index 8b1ea27..d59a0bb 100755
--- a/builder/kojid
+++ b/builder/kojid
@@ -3220,7 +3220,7 @@ class BaseImageTask(OzImageTask):
@returns:
a dict with some metadata about the image
"""
- img_opts = {'compress': 'gzip'}
+ img_opts = {'compress': 'xz'}
targ = self._do_target_image(self.base_img.base_image.identifier,
'docker', img_opts=img_opts)
return {'image': targ.target_image.data}
--
1.9.3
9 years, 3 months
Re: pungi for RHEL 7
by Troy Dawson
On Thu, 18 Dec 2014, Dennis Gilmore wrote:
>* -----BEGIN PGP SIGNED MESSAGE-----
*>* Hash: SHA1
*>>* On Thu, 18 Dec 2014 10:20:50 -0600
*>* Connie Sieh <csieh at fnal.gov
<https://admin.fedoraproject.org/mailman/listinfo/buildsys>> wrote:
*>>>* The pungi in git is clearly for Fedora. It can however be used for
*>>* RHEL 7 but a few "patches" are needed for it to work.
*>>>>* How would the patches best be put in pungi? There can be individual
*>>* command line options added that enable/disable features. A example
*>>* of this is there is no hfs support in RHEL 7 so a "nomacboot" command
*>>* line option could be added to disable this. Another option is a
*>>* single "rhel7" option that could cover all the rhel 7 patches. Which
*>>* way would be best?
*>>>>>>* The best way would be to add flags for the individual features.
*>>* Dennis
*>* -----BEGIN PGP SIGNATURE-----
*>* Version: GnuPG v2
*>
I have attached a patch for pungi 3.12.1 that provides a option
"nomacboot". This command line option tells pungi to not include macboot
in the compose. This is needed for EL7 as it does not provide HFS. The
default has not been changed.
--
Connie J. Sieh
Hi Connie,
This brings up a problem with the spec file.
For RHEL7 based distro's, there is only x86_64.
If the default if for macboot to be turn on for x86_64, then the spec file
needs to be updated to "Require: hfsplus-tools".
But, as you pointed out, RHEL7 doesn't provide HFS, so that's just silly.
Here is a modified patch, that instead of adding "nomacboot", sets macboot to
false by default, and adds the option "macboot" to turn on macboot.
Thoughts.
Troy Dawson
9 years, 4 months
koji 1.10?
by Pat Riehecky
Its been nearly a year - and about 100 commits - since Koji 1.09.
Any thoughts on a 1.10 release?
Pat
--
Pat Riehecky
Scientific Linux developer
Fermi National Accelerator Laboratory
www.fnal.gov
www.scientificlinux.org
9 years, 4 months
Koji import versus add-pkg
by Otto Han
Using koji what is the meaning of add-pkg ? I understand I use import
to add a package and tag-pkg or "call tagBuildBypass" to put a tag on
this package. Must I call add-pkg in between?
Thanks,
/Otto
9 years, 4 months
[PATCH] Test parent tag existence before query for its id
by Pavol Babincak
If client called:
$ koji add-tag new-tag-name --parent nonexistent-tag
it failed with error:
xmlrpclib.Fault: <Fault 1: 'exceptions.TypeError: unsubscriptable
object'>
---
hub/kojihub.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hub/kojihub.py b/hub/kojihub.py
index f45bdf7..90c1263 100644
--- a/hub/kojihub.py
+++ b/hub/kojihub.py
@@ -2718,9 +2718,9 @@ def create_tag(name, parent=None, arches=None, perm=None, locked=False, maven_su
# Does the parent exist?
if parent:
parent_tag = get_tag(parent)
- parent_id = parent_tag['id']
if not parent_tag:
raise koji.GenericError("Parent tag '%s' could not be found" % parent)
+ parent_id = parent_tag['id']
else:
parent_id = None
--
1.9.3
9 years, 4 months
[PATCH] Add new {pre,post}RPMSign plugin callbacks.
by Ralph Bean
I'd like to use these in Fedora Infrastructure for the fedmsg plugin so
we can see when rawhide rpms get signed by sigul.
---
hub/kojihub.py | 6 ++++++
koji/plugin.py | 2 ++
2 files changed, 8 insertions(+)
diff --git a/hub/kojihub.py b/hub/kojihub.py
index 3c7d5c1..1f8c0e2 100644
--- a/hub/kojihub.py
+++ b/hub/kojihub.py
@@ -24,6 +24,7 @@
import base64
import calendar
import cgi
+import copy
import koji
import koji.auth
import koji.db
@@ -5152,6 +5153,10 @@ def add_rpm_sig(an_rpm, sighdr):
#TODO[?] - if sighash is the same, handle more gracefully
nvra = "%(name)s-%(version)s-%(release)s.%(arch)s" % rinfo
raise koji.GenericError, "Signature already exists for package %s, key %s" % (nvra, sigkey)
+ callback_info = copy.copy(rinfo)
+ callback_info['sigkey'] = sigkey
+ callback_info['sighash'] = sighash
+ koji.plugin.run_callbacks('preRPMSign', attribute='sighash', old=None, new=sighash, info=callback_info)
insert = """INSERT INTO rpmsigs(rpm_id, sigkey, sighash)
VALUES (%(rpm_id)s, %(sigkey)s, %(sighash)s)"""
_dml(insert, locals())
@@ -5161,6 +5166,7 @@ def add_rpm_sig(an_rpm, sighdr):
fo = file(sigpath, 'wb')
fo.write(sighdr)
fo.close()
+ koji.plugin.run_callbacks('postRPMSign', attribute='sighash', old=None, new=sighash, info=callback_info)
def _scan_sighdr(sighdr, fn):
"""Splices sighdr with other headers from fn and queries (no payload)"""
diff --git a/koji/plugin.py b/koji/plugin.py
index ed51a5c..975b297 100644
--- a/koji/plugin.py
+++ b/koji/plugin.py
@@ -35,6 +35,8 @@ callbacks = {
'postBuildStateChange': [],
'preImport': [],
'postImport': [],
+ 'preRPMSign': [],
+ 'postRPMSign': [],
'preTag': [],
'postTag': [],
'preUntag': [],
--
1.9.3
9 years, 4 months
DNF vs. YUM in mock for epel configs
by Miroslav Suchý
Hi,
in mock you can choose which package manager will be used:
config_opts['package_manager'] = 'yum'
or
config_opts['package_manager'] = 'dnf'
Vít Ondruch pointed me that this may potentially lead to differences in results.
This will be likely no problem with Fedora, which change so fast.
But it may be problem for epel-* packages.
The solution can be to put line:
config_opts['package_manager'] = 'yum'
in
/etc/mock/epel-*-*.cfg
So epel packages will be always build by yum. Well until Epel-8, which will likely use DNF.
Comments? Objections?
--
Miroslav Suchy, RHCE, RHCDS
Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys
9 years, 4 months
