On Sat, 2015-03-07 at 16:20 +0800, Mathieu Bridon wrote:
On Fri, 2015-03-06 at 19:35 +0100, Pavol Babincak wrote:
> We'll need to take different approach then. By default pyrpkg will be
> backwards compatible and write sources in old format with md5 hash.
> pyrpkg's clients (e.g. fedpkg) will have a way to switch to new sources
> file format if their buildsystem infrastructure is prepared for that.
> In Fedora this means I need to finish my implementation of new sources
> format in fedpkg-minimal and only after this package will be in all
> supported buildroots we can switch fedpkg's default behaviour.
> I've untagged rpkg build from rawhide so developers won't rewrite their
> sources files in the way which Koji buildroots doesn't understand yet.
Seems like the best for now.
I'll send new patches that implement what you described above.
Patch 2/3 in the new series I just sent does just that:
- pyrpkg.sources can read/write sources files both in the
current format and the new (BSD-style) format
- pyrpkg defaults to writing sources files in the current
format, to preserve compatibility
- pyrpkg-based applications (like fedpkg) can override this
easily if they want to move to writing sources files in
the new (BSD-style) format
I believe with these patches merged you could make a new release of
rpkg, build it and update it for Fedora in all branches (including
EPEL), and nothing would change... except we'd now have the possibility
to eventually move to the new format whenever we decided to.
We should even be able to only move to the new format in newer Fedora
only if we wanted to, but it could be confusing, as the sources file
would be written in a given format based on the Fedora release the
packager is running, not the target Fedora branch for the build.
But it would all work nevertheless, as long as pyrpkg had been updated
in all branches.