On Fri, 2015-07-24 at 22:32 +0200, Dan HorĂ¡k wrote:
On Fri, 12 Jun 2015 23:26:34 +0200
Mathieu Bridon <bochecha(a)fedoraproject.org> wrote:
> From: Mathieu Bridon <bochecha(a)daitauha.fr>
>
> With the current code, trying to SSL-login with a bad certificate
> will
> just make it look like the client code is hanging.
>
> That's because it tries and tries again, silently, until it reaches
> it's maximum retry limit.
>
> But in the case of an SSL error, such as an expired client cert,
> there's really no point in retrying.
this change caused us troubles with the new s390 hub and had to be
reverted at the end
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1919798
aka "SysCallError: (-1, 'Unexpected EOF')"
with koji 1.10 (from Fedora Infra repos)
same result with the proposed patch
(
paste.fedoraproject.org/247278/63976214/)
only after reverting 4de27c52de I got successful newRepo
Well, yeah, the patchthat paste link **does** remove the 3 lines
introduced in 4de27c52de, so in effect it reverts it.
So I'm a bit puzzled as to how you could get the "same effect until
reverting 4de27c52de", because if you had applied that patch, it would
already have reverted 4de27c52de. :-/
--
Mathieu