Good point I'll add your patch and update the kojid.conf. thanks.
On Thu, Aug 7, 2014 at 10:01 AM, Mathieu Bridon
<bochecha(a)fedoraproject.org> wrote:
Disclaimer: I'm not a Koji maintainer
On Wed, 2014-08-06 at 17:42 +0200, Thomas wrote:
> + # check if spec path is defined
> + if len(scm_tuple) >= 5:
> + if scm_tuple[4]:
> + self.spec_path = scm_tuple[4] + '/'
Not commenting on whether this is desired or acceptable, but if you're
adding a new part to the allowed_scms tuple, could you also document it
in the kojid.conf file, to help admins know about this parameter?
Right now there already is an undocumented option (source_cmd) which
admins can only discover by reading the source code. I just sent a patch
to fix that, but it would be nice if we didn't add one more undocumented
option. :)
--
Mathieu
--
buildsys mailing list
buildsys(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys
--
Thomas