RFC - rename --old-chroot and --new-chroot
Please comment there:
https://github.com/rpm-software-management/mock/issues/331
Copy of Comment #0:
This is Request For Comments.
When systemd-nspawn has been added to mock, it brought a lot of bugs. For the transition
period we introduced
--old-chroot and --new-chroot. The intent was to steer toward the new chroot as mock
running containers is more secure
and everything. And maybe one day allow choosing between nspawn, docker, podman and
others.
But the world went another way. When people are interested in containers, they usually do
not want mock to run a
container, but they run mock inside of a container. When mock is running inside of
container then there is no need for
additional isolation and no one really wants to run another container inside of a
container. Therefore the --old-chroot
is a good choice when you run inside of a container.
My intention is to keep --old-chroot indefinitely and actually recommend it when mock is
running in a container. And
maybe later automatically choose old or new one depending on if mock is running in a
container or on bare metal.
In this situation, the names old/new are quite misleading. As it hints that you should
rather use the new stuff rather
than the old ones.
Therefore I want to rename (in fact, make alias) for those command-line options.
--old-chroot -> --simple-chroot
--new-chroot -> --container-chroot ??? I want to avoid confusion here whether this
option use container for chroot
(nspawn) or it is recommended to use when running in container.
I would like to hear your comments and ideas.
--
Miroslav Suchy, RHCA
Red Hat, Associate Manager ABRT/Copr, #brno, #fedora-buildsys