On 03/19/2015 12:16 PM, Mathieu Bridon wrote:
On Sat, 2015-03-07 at 16:20 +0800, Mathieu Bridon wrote:
> On Fri, 2015-03-06 at 19:35 +0100, Pavol Babincak wrote:
>> We'll need to take different approach then. By default pyrpkg will be
>> backwards compatible and write sources in old format with md5 hash.
>> pyrpkg's clients (e.g. fedpkg) will have a way to switch to new sources
>> file format if their buildsystem infrastructure is prepared for that.
>>
>> In Fedora this means I need to finish my implementation of new sources
>> format in fedpkg-minimal and only after this package will be in all
>> supported buildroots we can switch fedpkg's default behaviour.
>>
>> I've untagged rpkg build from rawhide so developers won't rewrite their
>> sources files in the way which Koji buildroots doesn't understand yet.
>
> Seems like the best for now.
>
> I'll send new patches that implement what you described above.
Patch 2/3 in the new series I just sent does just that:
- pyrpkg.sources can read/write sources files both in the
current format and the new (BSD-style) format
- pyrpkg defaults to writing sources files in the current
format, to preserve compatibility
- pyrpkg-based applications (like fedpkg) can override this
easily if they want to move to writing sources files in
the new (BSD-style) format
Patches looked fine and tests passed so merged and
released new rpkg -
1.32.
rpkg built in rawhide by now. I'll do the rest later. Hopefully this week.
--
Pavol Babincak
Release Engineering, Red Hat