On 03/06/2015 06:13 PM, Mathieu Bridon wrote:
On Fri, 2015-03-06 at 17:31 +0100, Pavol Babincak wrote:
> All patches looked ok so I've merged them in upstream and released
> rpkg-1.31. I've rebuilt rpkg in Fedora too: rpkg-1.31-1.fc23 and
> rpkg-1.31-1.fc22 (by now).
This might be problematic.
Say I run this new rpkg on Fedora 22, and upload a new source tarball in
the f21 branch.
The sources file will be in the new format.
In Koji, when building the package, inside the mock buildroot, the
previous rpkg gets installed, which won't be able to read the sources
file in the new format.
You should push it to all Fedora branches at the same time.
Thanks for pointing
this out. I realized this might break building
packages on custom buildsystems if they aren't prepared for this.
Package for fetching sources in buildroots of a build system needs to
know the new (BSD-like) sources format before developers start to commit
sources in this format. People might have an alternative implementation
for fetching the sources in their buildroots similar to Fedora's
fedpkg-minimal. So upgrading to new rpkg might not be a proper solution
We'll need to take different approach then. By default pyrpkg will be
backwards compatible and write sources in old format with md5 hash.
pyrpkg's clients (e.g. fedpkg) will have a way to switch to new sources
file format if their buildsystem infrastructure is prepared for that.
In Fedora this means I need to finish my implementation of new sources
format in fedpkg-minimal and only after this package will be in all
supported buildroots we can switch fedpkg's default behaviour.
I've untagged rpkg build from rawhide so developers won't rewrite their
sources files in the way which Koji buildroots doesn't understand yet.
Release Engineering, Red Hat