Kojihub fails after F14 -> f15 upgrade

[Anthony Joseph Messina]

After upgrading from Fedora 14 to Fedora 15, I'm having the following
issue when trying to access my koji web install.  I use Kerberos for my
private Koji instance.

I've see this:
http://www.redhat.com/archives/fedora-buildsys-list/2008-July/msg00022.html

I've checked my pg_hba.conf (it's the same as it was a few hours ago
with a working Fedora 14 Koji setup).  Of course, now I'm using
PostgreSQL 9.

I run the PostgreSQL service on the same box and am able to access other
PostgreSQL stuff without issue, using Kerberos.

Any help would be appreciated.  Thanks in advance.  -Anthony

MOD_PYTHON ERROR

ProcessId:      26326
Interpreter:    'messinet.com'

ServerName:     'messinet.com'
DocumentRoot:   '/var/www/egroupware/sitemgr/sitemgr-site'

URI:            '/koji/'
Location:       None
Directory:      '/usr/share/koji-web/scripts/'
Filename:       '/usr/share/koji-web/scripts/index.py'
PathInfo:       ''

Phase:          'PythonHandler'
Handler:        'kojiweb.publisher'

Traceback (most recent call last):

File "/usr/lib64/python2.7/site-packages/mod_python/importer.py", line
1537, in HandlerDispatch
    default=default_handler, arg=req, silent=hlist.silent)

File "/usr/lib64/python2.7/site-packages/mod_python/importer.py", line
1229, in _process_target
    result = _execute_target(config, req, object, arg)

File "/usr/lib64/python2.7/site-packages/mod_python/importer.py", line
1128, in _execute_target
    result = object(arg)

File "/usr/share/koji-web/lib/kojiweb/publisher.py", line 39, in handler
    return mod_python.publisher.handler(req)

File "/usr/lib64/python2.7/site-packages/mod_python/publisher.py",
line 213, in handler
    published = publish_object(req, object)

File "/usr/share/koji-web/lib/kojiweb/publisher.py", line 34, in
publish_object
    return old_publish_object(req, _genHTML(req, 'error.chtml'))

File "/usr/share/koji-web/lib/kojiweb/util.py", line 69, in _genHTML
    req._values['mavenEnabled'] = req._session.mavenEnabled()

File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1510,
in __call__
    return self.__func(self.__name,args,opts)

File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1740,
in _callMethod
    return proxy.__getattr__(name)(*args)

File "/usr/lib64/python2.7/xmlrpclib.py", line 1224, in __call__
    return self.__send(self.__name, args)

File "/usr/lib64/python2.7/xmlrpclib.py", line 1570, in __request
    verbose=self.__verbose

File "/usr/lib64/python2.7/xmlrpclib.py", line 1264, in request
    return self.single_request(host, handler, request_body, verbose)

File "/usr/lib64/python2.7/xmlrpclib.py", line 1312, in single_request
    response.msg,

ProtocolError: <ProtocolError for messinet.com/kojihub: 500 Internal
Server Error>

MODULE CACHE DETAILS

Accessed:       Wed Jun  8 19:04:04 2011
Generation:     0

_mp_0dec3ca8c086f5baed01b0d5504fa2b0 {
  FileName:     '/usr/share/koji-web/scripts/index.py'
  Instance:     1 [IMPORT]
  Generation:   1
  Modified:     Thu Dec 16 15:13:17 2010
  Imported:     Wed Jun  8 19:04:04 2011
}

[Anthony Joseph Messina]

On 06/08/2011 07:12 PM, Anthony Messina wrote:
> After upgrading from Fedora 14 to Fedora 15, I'm having the following
> issue when trying to access my koji web install.  I use Kerberos for my
> private Koji instance.
>
> I've see this:
> http://www.redhat.com/archives/fedora-buildsys-list/2008-July/msg00022.html

And I found
http://lists.fedoraproject.org/pipermail/buildsys/2011-May/003656.html

If I comment out

#from pgdb import _quoteparams

from /usr/lib/python2.7/site-packages/koji/db.py

the instance works again.  I subscribe to the list, I'm not sure how I
missed the messages in May.  -A

[Severin Gehwolf]

On Wed, 2011-06-08 at 20:17 -0500, Anthony Messina wrote:
> On 06/08/2011 07:12 PM, Anthony Messina wrote:
> > After upgrading from Fedora 14 to Fedora 15, I'm having the following
> > issue when trying to access my koji web install.  I use Kerberos for my
> > private Koji instance.
> >
> > I've see this:
> > http://www.redhat.com/archives/fedora-buildsys-list/2008-July/msg00022.html
>
> And I found
> http://lists.fedoraproject.org/pipermail/buildsys/2011-May/003656.html
>
> If I comment out
>
> #from pgdb import _quoteparams

I stumbled upon this one as well.

As far as I can tell _quoteparams is a python function of the PostgreSQL
python driver. Concluding from its name, this was never meant to be used
outside the driver itself. Now, there is an updated pg Python driver
part of F15 and this improper API usage is causing the problem.

The question is:
Is there a way to provide debug output/logging without using pg driver
internal functions?

Thanks,
Severin

[Mike McLean]

On 06/09/2011 09:13 AM, Severin Gehwolf wrote:
> As far as I can tell _quoteparams is a python function of the PostgreSQL
> python driver. Concluding from its name, this was never meant to be used
> outside the driver itself. Now, there is an updated pg Python driver
> part of F15 and this improper API usage is causing the problem.

I tend to read the single leading underscore as "use at your own risk" 
and double leading underscore as "no, really. don't use this." The 
double leading underscore is the standard for private names within 
python classes.
> The question is:
> Is there a way to provide debug output/logging without using pg driver
> internal functions?

Short of writing a separate quoting function, you could do something 
less optimal, like:
1) operation % parameters
or
2) "%r %r" % (operation,parameters)

The first doesn't quote, but does put the parameters in place. It might 
make some string-heavy commands hard to read. The second loses no data, 
but does not insert the parameters in place, which will be hard to read.

I'll be patching koji to do one of these shortly, unless I go crazy and 
write my own quoting function.