Two patches;
0001) Do not include boot.iso on any disc, per https://www.redhat.com/archives/fedora-devel-list/2009-January/msg02070.html
0002) the more cosmetic patch, I just so happened to see this; extraargs had two append() calls while "-o" and isofile were meant to be together. The patch makes this one extend call so that no accidents happen when someone inserts a line in between.
Kind regards,
Jeroen van Meeuwen -kanarip
On Fri, 2009-01-30 at 02:39 +0100, Jeroen van Meeuwen wrote:
- Do not include boot.iso on any disc, per
https://www.redhat.com/archives/fedora-devel-list/2009-January/msg02070.html
1 was already done upstream, https://fedorahosted.org/pungi/changeset/972240b9729dc023dff6a5ea519f2a55944...
Boot.iso needs to not be in the splitdirs that splittree will make or else the size estimation that splittree does will be off, and the first CD won't use up the extra space.
- the more cosmetic patch, I just so happened to see this; extraargs
had two append() calls while "-o" and isofile were meant to be together. The patch makes this one extend call so that no accidents happen when someone inserts a line in between.
Thanks, I'll apply that.
On Thu, 2009-01-29 at 17:56 -0800, Jesse Keating wrote:
On Fri, 2009-01-30 at 02:39 +0100, Jeroen van Meeuwen wrote:
- Do not include boot.iso on any disc, per
https://www.redhat.com/archives/fedora-devel-list/2009-January/msg02070.html
1 was already done upstream, https://fedorahosted.org/pungi/changeset/972240b9729dc023dff6a5ea519f2a55944...
Boot.iso needs to not be in the splitdirs that splittree will make or else the size estimation that splittree does will be off, and the first CD won't use up the extra space.
I think I see why your patch may be needed, boot.iso may still wind up on the DVD here. Looking closer.
Jesse Keating wrote:
On Fri, 2009-01-30 at 02:39 +0100, Jeroen van Meeuwen wrote:
- Do not include boot.iso on any disc, per
https://www.redhat.com/archives/fedora-devel-list/2009-January/msg02070.html
1 was already done upstream, https://fedorahosted.org/pungi/changeset/972240b9729dc023dff6a5ea519f2a55944...
That's only in splittree, which I presume is only executed for split media, right?
Kind regards,
Jeroen van Meeuwen -kanarip
On Fri, 2009-01-30 at 03:17 +0100, Jeroen van Meeuwen wrote:
That's only in splittree, which I presume is only executed for split media, right?
Yeah, I see now that it has to be done in both places. I forgot how the DVD mkisofs call was done, and I was only tested the split media stuff last night. Good catch.
buildsys@lists.fedoraproject.org
-
Jeroen van Meeuwen -
Jesse Keating