I spotted a couple of points where I think the Koji documentation could be improved:
In Koji/ServerHowTo#Koji_filesystem_skeleton you give an example
kojiadmin@localhost$ koji add-host kojibuilder1 x86_64 i386
which looks as if a simple user name style is sufficient. Near the end of the same document, in Koji/ServerHowTo#Add_the_host_entry_for_the_koji_builder_to_the_database, you say it like this:
kojiadmin@localhost$ koji add-host kojibuilder1.example.com i386 x86_64
Now it looks as if you're supposed to use the full host name, not a user name. It would be good to make those entries consistent and, if you do need the FQDN, to explain why.
In Koji/ExternalRepoServerBootstrap#Bootstrapping_a_new_External_Repo_Koji_buil d_environment you have a note
* NOTE: If you are adding multiple external repos, koji assigns a priority to each repo in FIFO order. This may cause updated packages to not be visible if a repo with older packages is ranked at a higher priority (lower numeric value). Use the -p flag to set specific repo priorities.
That suggests that repos with newer packages should be added first:
testing/$arch updates/$arch os/$arch
However in Koji/ExternalRepoServerBootstrap#Examples_of_urls_to_use_for_external_Reposi tories your examples list the os release repo before the updates repo, which would give the repo with the older packages the lower numeric value and therefore the higher priority.
Moray. "To err is human; to purr, feline."
OM International Limited - Unit B Clifford Court, Cooper Way - Carlisle CA3 0JG - United Kingdom Charity reg no: 1112655 - Company reg no: 5649412 (England and Wales)
From: Chris Tyler [mailto:chris@tylers.info] Sent: 16 April 2012 16:12
On Mon, 2012-04-16 at 16:05 +0100, Moray Henderson (ICT) wrote:
I spotted a couple of points where I think the Koji documentation
could be
improved:
It's a wiki, edits accepted :-)
I would expect that edits are more accepted when they come from someone who knows what they're talking about, though. I want to the documentation made better, not worse ;-)
If I did it, these are the changes I would make. If they're right, let me know and I'll apply for a Fedora Account and make them.
--- ServerHowTo.1.txt 2012-04-17 14:13:56.000000000 +0100 +++ ServerHowTo.2.txt 2012-04-17 14:15:39.000000000 +0100 @@ -511,7 +511,7 @@ Add the host entry for the koji builder to the database You will now need to add the koji builder to the database so that they can be utilized by kojij hub. Make sure you do this before you start kojid for the first time, or you'll need to manually remove entries from the sessions and users table before it can be run successfully.
-kojiadmin@localhost$ koji add-host kojibuilder1.example.com i386 x86_64 +kojiadmin@localhost$ koji add-host kojibuilder1 i386 x86_64 The first argument used after the add-host command should the username of the builder. The second argument is used to specify the architecture which the builder uses.
Add the host to the createrepo channel --- ExternalRepoServerBootstrap.1.txt 2012-04-17 14:16:23.000000000 +0100 +++ ExternalRepoServerBootstrap.2.txt 2012-04-17 14:16:58.000000000 +0100 @@ -31,12 +31,12 @@ all these examples use mirrors.kernel.org please find the closest mirror to yourself. Note that the Fedora minimal buildroots download ~100Mb then build dependencies on top. these are downloaded each build you can save alot of network bandwidth by using a local mirror or running through a caching proxy.
Fedora 10 -http://mirrors.kernel.org/fedora/releases/10/Everything/%5C$arch/os/ http://mirrors.kernel.org/fedora/updates/10/%5C$arch/ +http://mirrors.kernel.org/fedora/releases/10/Everything/%5C$arch/os/ CentOS 5 and EPEL -http://mirrors.kernel.org/centos/5/os/%5C$arch/ -http://mirrors.kernel.org/centos/5/updates/%5C$arch/ http://mirrors.kernel.org/fedora-epel/5/%5C$arch/ +http://mirrors.kernel.org/centos/5/updates/%5C$arch/ +http://mirrors.kernel.org/centos/5/os/%5C$arch/ Example tags and targets In the simplest setup, where you just want to build against what is available in the external repositories, you may want to go with a simple layout of dist-fX-build tags inheriting one another, and dist-fX-updates tags and targets that inherit the dist-fX-build tag and have external repos attached to them. This way, a dist-fY-build or dist-fY-updates tag will not automatically inherit the external repos of your dist-fX tags.
Moray. “To err is human; to purr, feline.”
On Tuesday, April 17, 2012, 9:37:56 AM, Moray Henderson wrote:
From: Chris Tyler [mailto:chris@tylers.info] Sent: 16 April 2012 16:12
On Mon, 2012-04-16 at 16:05 +0100, Moray Henderson (ICT) wrote:
I spotted a couple of points where I think the Koji documentation
could be
improved:
It's a wiki, edits accepted :-)
...
Add the host to the createrepo channel --- ExternalRepoServerBootstrap.1.txt 2012-04-17 14:16:23.000000000 +0100 +++ ExternalRepoServerBootstrap.2.txt 2012-04-17 14:16:58.000000000 +0100 @@ -31,12 +31,12 @@ all these examples use mirrors.kernel.org please find the closest mirror to yourself. Note that the Fedora minimal buildroots download ~100Mb then build dependencies on top. these are downloaded each build you can save alot of network bandwidth by using a local mirror or running through a caching proxy.
Fedora 10 -http://mirrors.kernel.org/fedora/releases/10/Everything/%5C$arch/os/ http://mirrors.kernel.org/fedora/updates/10/%5C$arch/ +http://mirrors.kernel.org/fedora/releases/10/Everything/%5C$arch/os/ CentOS 5 and EPEL -http://mirrors.kernel.org/centos/5/os/%5C$arch/ -http://mirrors.kernel.org/centos/5/updates/%5C$arch/ http://mirrors.kernel.org/fedora-epel/5/%5C$arch/ +http://mirrors.kernel.org/centos/5/updates/%5C$arch/ +http://mirrors.kernel.org/centos/5/os/%5C$arch/ Example tags and targets In the simplest setup, where you just want to build against what is available in the external repositories, you may want to go with a simple layout of dist-fX-build tags inheriting one another, and dist-fX-updates tags and targets that inherit the dist-fX-build tag and have external repos attached to them. This way, a dist-fY-build or dist-fY-updates tag will not automatically inherit the external repos of your dist-fX tags.
This might be a good time to bring the examples in the doc up to date. For example, to update the Fedora 10 to Fedora 17, and add the current versions of CentOS and RHEL.
Another one in Koji/ServerHowTo: /etc/koji-hub/hub.conf: If using SSL auth, these settings need to be valid and inline with other services configurations for kojiweb to allow logins. ProxyDNs should be set to the DN of the kojiweb certificate.
DNUsernameComponent = CN ProxyDNs = "/C=US/ST=Massachusetts/O=Example Org/OU=Example User/CN=example/emailAddress=example@example.com"
I had to remove the quotes around the ProxyDNs string (and restart httpd) before it would work. Pretty cool that it chose to greet me with 'céad míle fáilte' the first time I logged in!
Moray. “To err is human; to purr, feline.”
buildsys@lists.fedoraproject.org
-
Al Dunsmuir -
Chris Tyler -
Moray Henderson -
Moray Henderson (ICT)