mkisofs VolumeID 32 character limitation

[Joel Andres Granados]

Hi list:
still pocking at pungi...
Bug(I think): Pungi fails sometimes with a message that the mkisofs 
command failed.  On further investigation
      of the pungi log it seems that the label given to the iso is to 
long.  Looked at the mkisofs
      man page and found out that it only supports 32 characters in the 
iso label.  In my configuration
      it had a label of 33 "Fedora development x86_64 rescue"
Reason: There is a possibility for the cds iso images label to be Too 
long.  In the end the user
        defines the label because it is constructed from the pungi.conf 
variables:Prodcut_name, arch,
        version...
Possible fix: make sure to snip off the label before creating the 
isoimage.  With the patch I'm trying to cut the id to an allowable 
size.  Although I *do* cut the original name and I don't know what the 
effects are in the installations.  I did run pungi and it ended with no 
errors.
Comments: when the was shortened from the config file pungi executed 
successfully.  comments greatly appreciated.

The diff:
@@ -356,8 +359,8 @@
                         extraargs.append(os.path.join('%s-disc%s' % 
(self.topdir, disc), "ppc/mac"))

extraargs.append('-V')
-                extraargs.append('"%s %s %s Disc %s"' % 
(self.config.get('default', 'product_name'),
-                    self.config.get('default', 'version'), 
self.config.get('default', 'arch'), disc))
+                extraargs.append(('"%s %s %s Disc %s"' % 
(self.config.get('default', 'product_name'),
+                    self.config.get('default', 'version'), 
self.config.get('default', 'arch'), disc))[:32])

extraargs.append('-o')
                 extraargs.append(isofile)
@@ -417,8 +422,8 @@
                     extraargs.append(os.path.join('%s-disc%s' % 
(self.topdir, disc), "ppc/mac"))

extraargs.append('-V')
-            extraargs.append('"%s %s %s DVD"' % 
(self.config.get('default', 'product_name'),
-                self.config.get('default', 'version'), 
self.config.get('default', 'arch')))
+            extraargs.append(('"%s %s %s DVD"' % 
(self.config.get('default', 'product_name'),
+                self.config.get('default', 'version'), 
self.config.get('default', 'arch')))[:32])

extraargs.append('-o')
             extraargs.append(isofile)

[Jesse Keating]

On Thursday 12 April 2007 12:06:19 Joel Andres Granados wrote:
> Possible fix: make sure to snip off the label before creating the
> isoimage.  With the patch I'm trying to cut the id to an allowable
> size.  Although I *do* cut the original name and I don't know what the
> effects are in the installations.  I did run pungi and it ended with no
> errors.
> Comments: when the was shortened from the config file pungi executed
> successfully.  comments greatly appreciated.

I've been reluctant to fix this part of the code for a while.  I'm not really 
sure what a good thing to do here is, truncation can be kind of ugly, but it 
should have no effect upon the install, it'll just effect what the desktop 
shows as the volume should you mount the CD.

Perhaps this is a good enough solution for now, to prevent strange failures.  
I'll apply it soon, thanks.

[Joel Andres Granados]

Jesse Keating wrote:
> On Thursday 12 April 2007 12:06:19 Joel Andres Granados wrote:
> > Possible fix: make sure to snip off the label before creating the
> > isoimage.  With the patch I'm trying to cut the id to an allowable
> > size.  Although I *do* cut the original name and I don't know what the
> > effects are in the installations.  I did run pungi and it ended with no
> > errors.
> > Comments: when the was shortened from the config file pungi executed
> > successfully.  comments greatly appreciated.
>
> I've been reluctant to fix this part of the code for a while.  I'm not really 
> sure what a good thing to do here is, truncation can be kind of ugly, but it 
> should have no effect upon the install, it'll just effect what the desktop 
> shows as the volume should you mount the CD.

Thats what I thought as well,  I'll do an install test with one of the 
truncated IDs and see
if it works
> Perhaps this is a good enough solution for now, to prevent strange failures.  
> I'll apply it soon, thanks.

np
> --
> Fedora-buildsys-list mailing list
> [e-mail]
> https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

[Joel Andres Granados]

Joel Andres Granados wrote:
> Jesse Keating wrote:
> > On Thursday 12 April 2007 12:06:19 Joel Andres Granados wrote:
> > > Possible fix: make sure to snip off the label before creating the
> > > isoimage.  With the patch I'm trying to cut the id to an allowable
> > > size.  Although I *do* cut the original name and I don't know what the
> > > effects are in the installations.  I did run pungi and it ended with no
> > > errors.
> > > Comments: when the was shortened from the config file pungi executed
> > > successfully.  comments greatly appreciated.
> >
> > I've been reluctant to fix this part of the code for a while.  I'm 
> > not really sure what a good thing to do here is, truncation can be 
> > kind of ugly, but it should have no effect upon the install, it'll 
> > just effect what the desktop shows as the volume should you mount the 
> > CD.
>
> Thats what I thought as well,  I'll do an install test with one of the 
> truncated IDs and see
> if it works

Well the truncated ID works just fine, but thinking about the whole 
aesthetics of the situation I think it would be much better to just 
change the default value of the version parameter in the "pungi.conf" 
file.  The thing is that it has "development" set for the version 
parameter and this word is quite long.   IMO if it defaults to "devel" 
instead of "development", we would avoid using 6 characters and pungi 
would work with no problem when it is installed (Currently when pungi is 
installed from FC7 repo it will fail with the "ID to long" error if no 
change is made to the conf file. :( ).
If users start to scream about the situation too much the the ID should 
be truncated.  Just an idea.
Regards
Joel
> > Perhaps this is a good enough solution for now, to prevent strange 
> > failures.  I'll apply it soon, thanks.
>
> np
> > -- 
> > Fedora-buildsys-list mailing list
> > [e-mail]
> > https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
>
> -- 
> Fedora-buildsys-list mailing list
> [e-mail]
> https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

[Jesse Keating]

On Wednesday 09 May 2007 09:36:15 Joel Andres Granados wrote:
> Well the truncated ID works just fine, but thinking about the whole
> aesthetics of the situation I think it would be much better to just
> change the default value of the version parameter in the "pungi.conf"
> file.  The thing is that it has "development" set for the version
> parameter and this word is quite long.   IMO if it defaults to "devel"
> instead of "development", we would avoid using 6 characters and pungi
> would work with no problem when it is installed (Currently when pungi is
> installed from FC7 repo it will fail with the "ID to long" error if no
> change is made to the conf file. :( ).
> If users start to scream about the situation too much the the ID should
> be truncated.  Just an idea.
> Regards

Not a bad idea either (:  I'll make that change (if I remember it) when I 
finally get to the final tweaks to pungi for Fedora 7.

[Jesse Keating]

On Wednesday 09 May 2007 12:49:30 Jesse Keating wrote:
> Not a bad idea either (:  I'll make that change (if I remember it) when I
> finally get to the final tweaks to pungi for Fedora 7.

I just made this change.  I'm holding off on the other patch regarding this 
until I started doing Fedora 8 development and I revisit this problem.

[Joel Andres Granados]

Joel Andres Granados wrote:
> Hi list:
> still pocking at pungi...
> Bug(I think): Pungi fails sometimes with a message that the mkisofs 
> command failed.  On further investigation
>      of the pungi log it seems that the label given to the iso is to 
> long.  Looked at the mkisofs
>      man page and found out that it only supports 32 characters in the 
> iso label.  In my configuration
>      it had a label of 33 "Fedora development x86_64 rescue"
> Reason: There is a possibility for the cds iso images label to be Too 
> long.  In the end the user
>        defines the label because it is constructed from the pungi.conf 
> variables:Prodcut_name, arch,
>        version...
> Possible fix: make sure to snip off the label before creating the 
> isoimage.  With the patch I'm trying to cut the id to an allowable 
> size.  Although I *do* cut the original name and I don't know what the 
> effects are in the installations.  I did run pungi and it ended with 
> no errors.
> Comments: when the was shortened from the config file pungi executed 
> successfully.  comments greatly appreciated.
>
> The diff:
> @@ -356,8 +359,8 @@
>                         extraargs.append(os.path.join('%s-disc%s' % 
> (self.topdir, disc), "ppc/mac"))
>             extraargs.append('-V')
>            extraargs.append('"%s %s %s Disc %s"' % 
>
> (self.config.get('default', 'product_name'),
>                self.config.get('default', 'version'), 
>
> self.config.get('default', 'arch'), disc))
>            extraargs.append(('"%s %s %s Disc %s"' % 
>
> (self.config.get('default', 'product_name'),
>                self.config.get('default', 'version'), 
>
> self.config.get('default', 'arch'), disc))[:32])
>             extraargs.append('-o')
>             extraargs.append(isofile)
>
> @@ -417,8 +422,8 @@
>                     extraargs.append(os.path.join('%s-disc%s' % 
> (self.topdir, disc), "ppc/mac"))
>         extraargs.append('-V')
>        extraargs.append('"%s %s %s DVD"' % 
>
> (self.config.get('default', 'product_name'),
>            self.config.get('default', 'version'), 
>
> self.config.get('default', 'arch')))
>        extraargs.append(('"%s %s %s DVD"' % 
>
> (self.config.get('default', 'product_name'),
>            self.config.get('default', 'version'), 
>
> self.config.get('default', 'arch')))[:32])
>         extraargs.append('-o')
>         extraargs.append(isofile)
>
> -- 
> Fedora-buildsys-list mailing list
> [e-mail]
> https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

I missed a part of the code that also creates a volume ID.  Here is the 
revised diff:

--- pungi.py-0.3.0  2007-04-13 11:08:07.000000000 +0200
+++ pungi.py-0.3.1-JG   2007-04-13 13:37:47.000000000 +0200
@@ -356,8 +356,8 @@
                         extraargs.append(os.path.join('%s-disc%s' % 
(self.topdir, disc), "ppc/mac"))

extraargs.append('-V')
-                extraargs.append('"%s %s %s Disc %s"' % 
(self.config.get('default', 'product_name'),
-                    self.config.get('default', 'version'), 
self.config.get('default', 'arch'), disc))
+                extraargs.append(('"%s %s %s Disc %s"' % 
(self.config.get('default', 'product_name'),
+                    self.config.get('default', 'version'), 
self.config.get('default', 'arch'), disc))[:32])

extraargs.append('-o')
                 extraargs.append(isofile)
@@ -417,8 +417,8 @@
                     extraargs.append(os.path.join('%s-disc%s' % 
(self.topdir, disc), "ppc/mac"))

extraargs.append('-V')
-            extraargs.append('"%s %s %s DVD"' % 
(self.config.get('default', 'product_name'),
-                self.config.get('default', 'version'), 
self.config.get('default', 'arch')))
+            extraargs.append(('"%s %s %s DVD"' % 
(self.config.get('default', 'product_name'),
+                self.config.get('default', 'version'), 
self.config.get('default', 'arch')))[:32])

extraargs.append('-o')
             extraargs.append(isofile)
@@ -483,8 +483,8 @@
                 extraargs.append(os.path.join(self.workdir, 
"%s-rescueimage" % self.config.get('default', 'arch'), "ppc/mac"))

extraargs.append('-V')
-            extraargs.append('"%s %s %s Rescue"' % 
(self.config.get('default', 'product_name'),
-                    self.config.get('default', 'version'), 
self.config.get('default', 'arch')))
+            extraargs.append(('"%s %s %s Rescue"' % 
(self.config.get('default', 'product_name'),
+                    self.config.get('default', 'version'), 
self.config.get('default', 'arch')))[:32])

extraargs.append('-o')
             extraargs.append(isofile)