Koji+fedpkg: download sources to build SRPM

[John Morris]

Hi,

In order for koji to build from git, it must retrieve sources from the 
lookaside cache.  I believe that's the only reason the 'fedpkg' package 
is required in a build target's 'srpm-build' group.

The default fedpkg.conf installed by the RPM is configured with the 
Fedora lookaside server URLs.  Of course that doesn't work in my shop, 
where we run our own koji infra.

I hacked koji to pull the host's /etc/fedpkg.conf file into the mock 
chroot, the same way koji does out of the box with /etc/hosts.  The 
patch is attached.

Koji and the Fedora packaging tools have been great tools for us.  We're 
using koji, mock, sigul, fedpkg and other components.  It's been a 
little frustrating at times, though, frequently dealing with what seems 
like configuration data that's hardcoded into the source.

I'm guessing that addressing that is low-priority, since the main 
consumers of these tools are the users of the Fedora build 
infrastructure.  I occasionally get the bug to 'fix' stuff.  Most 
recently, I set up a subclassed fedpkg tool that works with the 
peculiarities of our configuration (configuration locations, branch 
nomenclature, etc.).  It turned out to be a bit hairy, and it wouldn't 
be tough to fix fedpkg.  Would patches be welcome?  It would be pretty 
valuable to have private instances supported a little better.

Thanks-

	John




--- koji-1.7.0/koji/__init__.py~        2012-05-31 14:05:43.000000000 -0500
+++ koji-1.7.0/koji/__init__.py 2012-08-31 17:48:54.411897132 -0500
@@ -1266,6 +1266,9 @@
          etc_hosts = file('/etc/hosts')
          files['etc/hosts'] = etc_hosts.read()
          etc_hosts.close()
+        fedpkg_conf = file('/etc/rpkg/fedpkg.conf')
+        files['etc/rpkg/fedpkg.conf'] = fedpkg_conf.read()
+        fedpkg_conf.close()
      mavenrc = ''
      if opts.get('maven_opts'):
          mavenrc = 'export MAVEN_OPTS="%s"\n' % ' 
'.join(opts['maven_opts'])

[Jesse Keating]

On 09/01/2012 09:45 AM, John Morris wrote:
>  In order for koji to build from git, it must retrieve sources from the
>  lookaside cache.  I believe that's the only reason the 'fedpkg' package
>  is required in a build target's 'srpm-build' group. 
Note, the fedpkg used here in our koji land is a trimmed down fedpkg 
that only has the "sources" capability built in.  This greatly reduces 
the dependency list of this package and speeds up the srpm creation 
process (and prevents some chicken/egg problems where you need a new 
fedpkg to fix a bug, but you keep triggering the bug when creating the 
srpm by using fedpkg...)

Perhaps your site can do the same thing?

-- 
Help me fight child abuse: http://tinyurl.com/jlkcourage

- jlk

[Dennis Gilmore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

El Tue, 04 Sep 2012 10:28:54 -0700
Jesse Keating <jkeating(a)j2solutions.net&gt; escribió:
>  On 09/01/2012 09:45 AM, John Morris wrote:
>  >
>  > In order for koji to build from git, it must retrieve sources from
>  > the lookaside cache.  I believe that's the only reason the 'fedpkg'
>  > package is required in a build target's 'srpm-build' group.
>  
>  Note, the fedpkg used here in our koji land is a trimmed down fedpkg 
>  that only has the "sources" capability built in.  This greatly
>  reduces the dependency list of this package and speeds up the srpm
>  creation process (and prevents some chicken/egg problems where you
>  need a new fedpkg to fix a bug, but you keep triggering the bug when
>  creating the srpm by using fedpkg...)
>  
>  Perhaps your site can do the same thing?
>  
>  

Jesse,

we are using fedpkg as is shipped in fedora.  we never have setup using
something else, at some point we will but its not the case today.

Dennis
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.18 (GNU/Linux)
>
> iEYEARECAAYFAlBJUr8ACgkQkSxm47BaWfcWMgCgmMFcJKC4+TNUgfrHhrfrIO2P
> OyYAnjrlscnsWK7eeot0iDfGTSYZf0ET
> =g011
> -----END PGP SIGNATURE-----
>

[Jesse Keating]

On 09/06/2012 06:49 PM, Dennis Gilmore wrote:
>  Jesse,
>
>  we are using fedpkg as is shipped in fedora.  we never have setup using
>  something else, at some point we will but its not the case today. 
Not true for the epel5 environment, and internally at Red Hat we're 
using the fake fedpkg for all the environments.

-- 
Help me fight child abuse: http://tinyurl.com/jlkcourage

- jlk