On 11/13/14 8:31 AM, Pavol Babincak wrote:
On 10/30/2014 09:21 PM, Mike Bonnet wrote:
> Hi. Attached are a couple of enhancements to rpkg. The first adds a
> --runas option. This allows you to run Koji commands as a different
> user, if the Koji hub has been configured to allow you to do so. This
> is useful for automation that launches builds on behalf of other users.
Looks ok. Applied.
> The other patch fixes support for password authentication (it has never
> worked correctly) and cleans up Koji session creation, so all relevant
> config options are passed through to the new session. This should
> improve compatibility between the Koji cli and rpkg. Let me know if
> there are any questions.
I'm not sure about this patch. You modified "defaults" dictionary:
- removed pkgurl key,
pkgurl has been deprecated in Koji for a very long time. It appears
nowhere else in the rpkg codebase, and is not passed through to the Koji
session or saved as part of the Commands object. Removing it will have
no effect on any users.
- changed type and value of krbservice
Changing the default to None just lets the default handling fall through
to the Koji ClientSession, where it defaults to the prevous value of
"host". This will cause no change in behavior to any users.
Are we sure this won't break clients which might depend on this?
Yes, I have a high level of confidence that this won't break anyone.
The only change in behavior will be that some config parameters in the
Koji config which were not being respected before (like keepalive,
max_retries, anon_retry, etc.) now will be, which should improve
consistency between the Koji cli and rpkg-based clis.
Thanks for the review!