RE: problems with orphanskill feature

[Michael E Brown]

Do you want to do the patch or me? It will be tomorrow morning before I can get to it. (or
very late tonight.)
--
Michael


-----Original Message-----
From: Clark Williams [mailto:[e-mail]]
Sent: Thu 9/27/2007 4:11 PM
To: Brown, Michael E
Cc: Jesse Keating; fedora-buildsys-list(a)redhat.com
Subject: Re: problems with orphanskill feature
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael E Brown wrote:
>  On Thu, Sep 27, 2007 at 01:30:15PM -0500, Clark Williams wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Michael/Jesse,
> >
> > We're seeing odd failures with mock and the orphanskill feature. What seems to
> happen
> > is that the '; mock-helper orphanskill <rootdir>'  string is tacked
> onto a command
> > which is passed to do_chroot() and after the main command is run, an attempt is made
> > to run mock-helper (which is not installed in the chroot). So people are seeing a
> > "File not found" message after a successful command.
> >
> > Now it looks like to me that part of the reason for an orphanskill was that the do()
> > routine might hang until all the child processes are done, so I'm loathe to just
> run
> > the orphanskill after the do_chroot() is finished (I suspect twisty lines of logic,
> > all alike). Seems like we can do a couple of things:
> >
> > 1. Copy mock-helper into each chroot, so it's available for orphanskill
> > 2. Back out the orphanskill logic and try again
> >
> > Option #1 is somewhat easy, if kinda ugly (not sure I like the idea of scattering a
> > setuid-root program into all our build roots). Option #2 requires that we look at
> the
> > code in all the do_* and do() routines to make sure that orphanskill runs when we
> > need it to. Ideally I'd like to insure that orphanskill runs *outside* the chroot
> and
> > that it's not needed to keep self.do() from hanging.
> >
> > What you guys think?
>  
>  How about we just run two commands in a row? I see the comment but don't
>  really see why. Line 973, we dont need to run orphanskill if it isnt
>  chroot. For the my.do_chroot() on line 975, it looks like we could just
>  do a my.do_chroot() followed by a normal os.system(). 
That was my first thought, but I was concerned that we might be missing something
subtle in the timeout code (hence my email to you :)).

If you think we can just run the orphanskill stuff after running the do_chroot() then
I say that's the way to go.

>  
>  The problem it is trying to fix is if the rpmbuild process spawns child
>  processes that fork and never exit. I believe this was seen in some code
>  that was running in the rpmbuild as a unit test?
>  
>  We should also be cc-ing fedora-buildsys-list. (done) 
wups (looks shamefaced)

>  
>  I also understand Jesse's sentiment to just back it out.  If it is going
>  to take more than a day or two to fix, we could just back it out. 
Let's try running it right after the rpmbuild. If that doesn't work right, then
we
can just comment it out while we take a closer look at it.

Clark
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iD8DBQFG/BxuqA4JVb61b9cRAkAIAJ0cusVhhetlhnNJA5RWTkcD4cHG5wCcD5Rb
> aQo57BZBD1ME0FLDj6nARq4=
> =itpW
> -----END PGP SIGNATURE-----

problems with orphanskill feature

[Clark Williams]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael_E_Brown(a)Dell.com wrote:
>  Do you want to do the patch or me? It will be tomorrow morning before
> I 
can get to it. (or very late tonight.)
>  --
>  Michael
>
>  
I can do it, although I've somehow managed to hose my git
configuration so that I can't seem to push to our fedoraproject
repository.


I've got a fix for BZ 303791 (just changing the search string for now
to match the resolvdep output) and I'd like to get that up before
trying the orphanskill fix. Since I never actually got bodhi working
last time, I think I should give it another go. I'll make the BZ fix
in devel/F-7/FC-6 and when I get that straightened out we can try an
orphanskill fix in rawhide.

Clark
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iD8DBQFG/CJwHyuj/+TTEp0RAqinAKDZtJS8k2L7qmiNAQ+Kj6AUjHSqZACgidms
> ydMyyZlburkHY0KN9xkiUxA=
> =TvvK
> -----END PGP SIGNATURE-----