Jonathan Lebon got the first standard test (that I know of) into dist-git. Woooo!
The rpm-ostree Ansible wrapper invokes tests are packaged in the source RPM upstream.
In order to do this it needs to be able to assume that the tests are invoked in an actual dist-git repo, and it can use the spec file to access the sources.
I always assumed the spec [0] implied that the tests should be executed in an actual dist-git repo checkout, but Jonathan pointed out that this isn't completely clear.
I'd like to edit the spec to clear this up. I'd like to insert an item after "5." in the list here:
https://fedoraproject.org/wiki/Changes/InvokingTests#Invocation
with:
6. The playbook must be executed within the dist-git repository checkout and not copied elsewhere.
- The playbook may refer to any other file in the dist-git checkout or its tests/ directory via a relative path.
Does that make sense?
Cheers,
Stef
On Tue, Aug 22, 2017 at 04:35:29PM +0200, Stef Walter wrote:
Jonathan Lebon got the first standard test (that I know of) into dist-git. Woooo!
The rpm-ostree Ansible wrapper invokes tests are packaged in the source RPM upstream.
In order to do this it needs to be able to assume that the tests are invoked in an actual dist-git repo, and it can use the spec file to access the sources.
I always assumed the spec [0] implied that the tests should be executed in an actual dist-git repo checkout, but Jonathan pointed out that this isn't completely clear.
I'd like to edit the spec to clear this up. I'd like to insert an item after "5." in the list here:
https://fedoraproject.org/wiki/Changes/InvokingTests#Invocation
with:
The playbook must be executed within the dist-git repository checkout and not copied elsewhere.
- The playbook may refer to any other file in the dist-git checkout or its tests/ directory via a relative path.
Does that make sense?
Sounds fine to me :)
Pierre
-
Dusty Mabe -
Pierre-Yves Chibon -
Stef Walter