Understanding abidiff failures in Zuul+rpminspect

[Miro Hrončok]

Hello,

in this PR:

https://src.fedoraproject.org/rpms/python3.11/pull-request/64

In this Zuul CI job:

https://fedora.softwarefactory-project.io/zuul/build/69d10a1f21e14d959e02231...

I see:

Running abidiff inspection...        FAIL

In this rpminspect report:

https://fedora.softwarefactory-project.io/rpminspect-report/?url=https://fed...

(JSON attached)

I see abidiff results as listed as "OK":

"ABI comparison ended unexpectedly."

"Command: abidiff 
/var/tmp/rpminspect/local.KjDvKK/before/x86_64/python3-libs-3.11.0~b3-8.fc37.x86_64//usr/lib64/libpython3.11.so.1.0 
/var/tmp/rpminspect/local.KjDvKK/after/x86_64/python3-libs-3.11.0~b4-1.fc37.x86_64//usr/lib64/libpython3.11.so.1.0 
Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables 
changes summary: 0 Removed, 0 Changed, 0 Added variable Function symbols 
changes summary: 0 Removed, 2 Added function symbols not referenced by debug 
info Variable symbols changes summary: 0 Removed, 0 Added variable symbol not 
referenced by debug info 2 Added function symbols not referenced by debug info: 
[A] _PyImport_GetModuleAttr [A] _PyImport_GetModuleAttrString "

What does that even mean?

Why is the result a FAIL when it is listed as OK?

Why is it listed as OK, when it says it ended unexpectedly?

What do I read from the results? Is it OK, not OK, broken?

Thanks,

[Miro Hrončok]

On 12. 07. 22 11:10, Miro Hrončok wrote:
> Hello,
>
> in this PR:
>
> https://src.fedoraproject.org/rpms/python3.11/pull-request/64
>
> In this Zuul CI job:
>
> https://fedora.softwarefactory-project.io/zuul/build/69d10a1f21e14d959e02231...
>
> I see:
>
> Running abidiff inspection...        FAIL
>
> In this rpminspect report:
>
> https://fedora.softwarefactory-project.io/rpminspect-report/?url=https://fed...
>
> (JSON attached)
>
> I see abidiff results as listed as "OK":
>
> "ABI comparison ended unexpectedly."
>
> "Command: abidiff 
> /var/tmp/rpminspect/local.KjDvKK/before/x86_64/python3-libs-3.11.0~b3-8.fc37.x86_64//usr/lib64/libpython3.11.so.1.0 
> /var/tmp/rpminspect/local.KjDvKK/after/x86_64/python3-libs-3.11.0~b4-1.fc37.x86_64//usr/lib64/libpython3.11.so.1.0 
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables 
> changes summary: 0 Removed, 0 Changed, 0 Added variable Function symbols 
> changes summary: 0 Removed, 2 Added function symbols not referenced by debug 
> info Variable symbols changes summary: 0 Removed, 0 Added variable symbol not 
> referenced by debug info 2 Added function symbols not referenced by debug info: 
> [A] _PyImport_GetModuleAttr [A] _PyImport_GetModuleAttrString "
>
> What does that even mean?
>
> Why is the result a FAIL when it is listed as OK?
>
> Why is it listed as OK, when it says it ended unexpectedly?
>
> What do I read from the results? Is it OK, not OK, broken?
>
> Thanks,

I've also tried to get the same output locally:

$ abidiff b3-8/usr/lib64/libpython3.11.so.1.0 b4-1/usr/lib64/libpython3.11.so.1.0
Functions changes summary: 0 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
Function symbols changes summary: 0 Removed, 2 Added function symbols not 
referenced by debug info
Variable symbols changes summary: 0 Removed, 0 Added variable symbol not 
referenced by debug info

2 Added function symbols not referenced by debug info:

[A] _PyImport_GetModuleAttr
   [A] _PyImport_GetModuleAttrString

$ echo $?
4

However, should without debuginfo, it's kinda not useful.
Should rpminspect run it like this?

$ abidiff b3-8/usr/lib64/libpython3.11.so.1.0 --d1 b3-8/usr/lib/debug/ 
b4-1/usr/lib64/libpython3.11.so.1.0 --d2 b4-1/usr/lib/debug/
Functions changes summary: 0 Removed, 2 Changed (121 filtered out), 2 Added 
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

2 Added functions:

[A] 'function PyObject* _PyImport_GetModuleAttr(PyObject*, PyObject*)' 
{_PyImport_GetModuleAttr}
   [A] 'function PyObject* _PyImport_GetModuleAttrString(const char*, const 
char*)'    {_PyImport_GetModuleAttrString}

2 functions with some indirect sub-type change:
...snip...

[David Cantrell]

On Tue, Jul 12, 2022 at 11:10:55AM +0200, Miro Hrončok wrote:
> Hello,
>
> in this PR:
>
> https://src.fedoraproject.org/rpms/python3.11/pull-request/64
>
> In this Zuul CI job:
>
> https://fedora.softwarefactory-project.io/zuul/build/69d10a1f21e14d959e02231...
>
> I see:
>
> Running abidiff inspection...        FAIL
>
> In this rpminspect report:
>
> https://fedora.softwarefactory-project.io/rpminspect-report/?url=https://fed...
>
> (JSON attached)
>
> I see abidiff results as listed as "OK":
>
> "ABI comparison ended unexpectedly."
>
> "Command: abidiff /var/tmp/rpminspect/local.KjDvKK/before/x86_64/python3-libs-3.11.0~b3-8.fc37.x86_64//usr/lib64/libpython3.11.so.1.0 /var/tmp/rpminspect/local.KjDvKK/after/x86_64/python3-libs-3.11.0~b4-1.fc37.x86_64//usr/lib64/libpython3.11.so.1.0
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables
> changes summary: 0 Removed, 0 Changed, 0 Added variable Function symbols
> changes summary: 0 Removed, 2 Added function symbols not referenced by debug
> info Variable symbols changes summary: 0 Removed, 0 Added variable symbol
> not referenced by debug info 2 Added function symbols not referenced by
> debug info: [A] _PyImport_GetModuleAttr [A] _PyImport_GetModuleAttrString "
>
> What does that even mean?
>
> Why is the result a FAIL when it is listed as OK?
>
> Why is it listed as OK, when it says it ended unexpectedly?
>
> What do I read from the results? Is it OK, not OK, broken?

This is something I ran in to recently and it's currently a known bug that I
have not yet resolved.  There is an upstream bug filed if you want to follow
that.

Thanks,