Where is gating.yaml fetched from? How does the branch relate to product_versions?

[Miro Hrončok]

I wonder, if gating.yaml has this section:

product_versions:
   - fedora-*

Where is gating.yaml actually taken from? Is it the branch that is being gated, 
or always master, or something else?

Why is the "product_version" not determined by the branch?

Thanks for clarifying.

[Lukas Holecek]

I cannot find a reason we decided for the "product_versions" field to be required in "gating.yaml".

It makes more sense for the product_versions to be inherited from the policy with the RemoveRule (i.e. the policy which initiated fetching the gating.yaml).

I've created issue for this: https://pagure.io/greenwave/issue/468

[Lukas Holecek]

The "gating.yaml" is fetched from git repo based on the URL of a specific build in Koji.

The file is fetched from specific git commit (the revision is part of the build URL).

More specifically:

1. Greewave gets the build data "koji call getBuild $NVR",
2. parses URL in "source" field [1] and
3. constructs the "gating.yaml" URL based on DIST_GIT_URL_TEMPLATE specified in Greenwave configuration. [2]

[1] We need namespace ("rpms" or "containers" etc.), git revision and package name (or rather git repository name).
[2] The URL template is something like "{DIST_GIT_BASE_URL}/{pkg_namespace}/{pkg_name}/raw/{rev}/f/gating.yaml".

[Pierre-Yves Chibon]

On Tue, Jul 30, 2019 at 01:40:53PM -0000, Lukas Holecek wrote:
> The "gating.yaml" is fetched from git repo based on the URL of a specific build in Koji.
>
> The file is fetched from specific git commit (the revision is part of the build URL).
>
> More specifically:
> Greewave gets the build data "koji call getBuild $NVR",
> parses URL in "source" field [1] and

Note that you should use "source" from the "extra" dictionary.
Source could be the branch name, like:
git+https://src.fedoraproject.org/rpms/fedora-gather-easyfix.git#master
while "extra": {"source" will always return you the git hash:
git+https://src.fedoraproject.org/rpms/fedora-gather-easyfix.git#2d0dff00ff0085d...

Would you like me to open a ticket for this?

Best,
Pierre

[Lukas Holecek]

On Tue, Jul 30, 2019 at 3:57 PM Pierre-Yves Chibon 
wrote:
> On Tue, Jul 30, 2019 at 01:40:53PM -0000, Lukas Holecek wrote:
> > The "gating.yaml" is fetched from git repo based on the URL of a
>
> specific build in Koji.
> > The file is fetched from specific git commit (the revision is part of
>
> the build URL).
> > More specifically:
> > Greewave gets the build data "koji call getBuild $NVR",
> > parses URL in "source" field [1] and
>
> Note that you should use "source" from the "extra" dictionary.
> Source could be the branch name, like:
> git+https://src.fedoraproject.org/rpms/fedora-gather-easyfix.git#master
> while "extra": {"source" will always return you the git hash:
> git+
> https://src.fedoraproject.org/rpms/fedora-gather-easyfix.git#2d0dff00ff0085d...

Ah, I think we did this in past, but some builds where missing "extra"
field.
> Would you like me to open a ticket for this?

Please do and let's discuss it there.
> Best,
> Pierre
> _______________________________________________
> CI mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]