zuul rpm-install-test false positives

[Zbigniew Jędrzejewski-Szmek]

[resend, since the first one seems to have gotten stuck permanently in the moderation
queue]

Hi,

I would like to make the CI pass for systemd builds. I added an rpminspect.yaml file [1]
to disable a bunch rpminspect checks, and rpminspect passes now. But I'm stuck on
rpm-install-test, which dutifully informs me that
>  package systemd-247.2-3.fc34.x86_64 conflicts with
>  systemd-standalone-tmpfiles < 247.2-3.fc34^ provided by
> systemd-standalone-tmpfiles-247.2-3.fc34.x86_64 
Duh, no surprise, I added the
Conflicts myself ;)

I do NOT want to disable the test completely. I am very much interested in CI catching
the
case where packages cannot be installed or upgraded. I'd like just to either tell it
that
it should ignore systemd-standalone-tmpfiles and systemd-standalone-sysusers, or ideally,
it would be able to guess on its own that if there are Conflicts between subpackages from
the same built, that is intentional and should be ignored.

I looked at the docs [2, 3], but I don't see anything relevant.

[1] https://src.fedoraproject.org/rpms/systemd/c/7e740c5252c3291d67def67d33e5...
[2] https://docs.fedoraproject.org/en-US/ci/generic_tests/#_installability
[3]
https://lists.fedoraproject.org/archives/list/[e-mail]/...

Zbyszek

[Zbigniew Jędrzejewski-Szmek]

On Fri, Feb 05, 2021 at 12:14:35PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
>  [resend, since the first one seems to have gotten stuck permanently
> in the moderation queue]
>  
>  Hi,
>  
>  I would like to make the CI pass for systemd builds. I added an rpminspect.yaml file [1]
>  to disable a bunch rpminspect checks, and rpminspect passes now. But I'm stuck on
>  rpm-install-test, which dutifully informs me that
>  > package systemd-247.2-3.fc34.x86_64 conflicts with
>  > systemd-standalone-tmpfiles < 247.2-3.fc34^ provided by
> systemd-standalone-tmpfiles-247.2-3.fc34.x86_64
>  Duh, no surprise, I added the Conflicts myself ;)
>  
>  I do NOT want to disable the test completely. I am very much interested in CI catching
> the
>  case where packages cannot be installed or upgraded. I'd like just to either tell it
> that
>  it should ignore systemd-standalone-tmpfiles and systemd-standalone-sysusers, or
> ideally,
>  it would be able to guess on its own that if there are Conflicts between subpackages
> from
>  the same built, that is intentional and should be ignored.
>  
>  I looked at the docs [2, 3], but I don't see anything relevant.
>  
>  [1]
> https://src.fedoraproject.org/rpms/systemd/c/7e740c5252c3291d67def67d33e5...
>  [2] https://docs.fedoraproject.org/en-US/ci/generic_tests/#_installability
>  [3]
> https://lists.fedoraproject.org/archives/list/[e-mail]/...
And to follow-up on this: I added config for rpm-inspect:
an .abignore file [1] and rpminspect.yaml [2] file. At least [1]
worked fine for a while, but suddenly the false positives are back [3].
Did the interface change?

[1] https://src.fedoraproject.org/rpms/systemd/blob/rawhide/f/libsystemd-shar...
[2] https://src.fedoraproject.org/rpms/systemd/blob/rawhide/f/rpminspect.yaml
[3]
https://fedora.softwarefactory-project.io/rpminspect-report/?url=https://...

Zbyszek

[Tristan Cacqueray]

On Fri, Feb 05, 2021 at 12:14 Zbigniew Jędrzejewski-Szmek wrote:
>  [resend, since the first one seems to have gotten stuck permanently
> in the moderation queue]
>
>  Hi,
>
>  I would like to make the CI pass for systemd builds. I added an rpminspect.yaml file [1]
>  to disable a bunch rpminspect checks, and rpminspect passes now. But I'm stuck on
>  rpm-install-test, which dutifully informs me that
> > package systemd-247.2-3.fc34.x86_64 conflicts with
> > systemd-standalone-tmpfiles < 247.2-3.fc34^ provided by
> systemd-standalone-tmpfiles-247.2-3.fc34.x86_64
>  Duh, no surprise, I added the Conflicts myself ;)
>
>  I do NOT want to disable the test completely. I am very much interested in CI catching
> the
>  case where packages cannot be installed or upgraded. I'd like just to either tell it
> that
>  it should ignore systemd-standalone-tmpfiles and systemd-standalone-sysusers, or
> ideally,
>  it would be able to guess on its own that if there are Conflicts between subpackages
> from
>  the same built, that is intentional and should be ignored.
>
>  I looked at the docs [2, 3], but I don't see anything relevant.
>
>  [1]
> https://src.fedoraproject.org/rpms/systemd/c/7e740c5252c3291d67def67d33e5...
>  [2] https://docs.fedoraproject.org/en-US/ci/generic_tests/#_installability
>  [3]
> https://lists.fedoraproject.org/archives/list/[e-mail]/...
>  
Hi Zbigniew,

The rpm-install-test job is using this role:

https://pagure.io/zuul-distro-jobs/blob/master/f/roles/repo-install-rpm/t...

It seems like a good idea to add a variable to add exclude arguments to the
repoquery command L15. Would that work for you?

Regards,
-Tristan

[Zbigniew Jędrzejewski-Szmek]

On Fri, Feb 05, 2021 at 02:27:14PM +0000, Tristan Cacqueray wrote:
>  
>  On Fri, Feb 05, 2021 at 12:14 Zbigniew Jędrzejewski-Szmek wrote:
>  > [resend, since the first one seems to have gotten stuck permanently in the
> moderation queue]
>  >
>  > Hi,
>  >
>  > I would like to make the CI pass for systemd builds. I added an rpminspect.yaml file
> [1]
>  > to disable a bunch rpminspect checks, and rpminspect passes now. But I'm stuck
> on
>  > rpm-install-test, which dutifully informs me that
>  >> package systemd-247.2-3.fc34.x86_64 conflicts with
>  >> systemd-standalone-tmpfiles < 247.2-3.fc34^ provided by
> systemd-standalone-tmpfiles-247.2-3.fc34.x86_64
>  > Duh, no surprise, I added the Conflicts myself ;)
>  >
>  > I do NOT want to disable the test completely. I am very much interested in CI
> catching the
>  > case where packages cannot be installed or upgraded. I'd like just to either
> tell it that
>  > it should ignore systemd-standalone-tmpfiles and systemd-standalone-sysusers, or
> ideally,
>  > it would be able to guess on its own that if there are Conflicts between subpackages
> from
>  > the same built, that is intentional and should be ignored.
>  >
>  > I looked at the docs [2, 3], but I don't see anything relevant.
>  >
>  > [1]
> https://src.fedoraproject.org/rpms/systemd/c/7e740c5252c3291d67def67d33e5...
>  > [2] https://docs.fedoraproject.org/en-US/ci/generic_tests/#_installability
>  > [3]
> https://lists.fedoraproject.org/archives/list/[e-mail]/...
>  >
>  
>  Hi Zbigniew,
>  
>  The rpm-install-test job is using this role:
>  
>
> https://pagure.io/zuul-distro-jobs/blob/master/f/roles/repo-install-rpm/t...
>  
>  It seems like a good idea to add a variable to add exclude arguments to the
>  repoquery command L15. Would that work for you? 
Yeah, that should work.
Thanks for looking into this. 

Zbyszek

[Tristan Cacqueray]

On Fri, Feb 05, 2021 at 14:27 Tristan Cacqueray wrote:
>  On Fri, Feb 05, 2021 at 12:14 Zbigniew Jędrzejewski-Szmek wrote:
> > [resend, since the first one seems to have gotten stuck permanently in the moderation
> queue]
> >
> > Hi,
> >
> > I would like to make the CI pass for systemd builds. I added an rpminspect.yaml file
> [1]
> > to disable a bunch rpminspect checks, and rpminspect passes now. But I'm stuck
> on
> > rpm-install-test, which dutifully informs me that
> >> package systemd-247.2-3.fc34.x86_64 conflicts with
> >> systemd-standalone-tmpfiles < 247.2-3.fc34^ provided by
> systemd-standalone-tmpfiles-247.2-3.fc34.x86_64
> > Duh, no surprise, I added the Conflicts myself ;)
> >
> > I do NOT want to disable the test completely. I am very much interested in CI
> catching the
> > case where packages cannot be installed or upgraded. I'd like just to either tell
> it that
> > it should ignore systemd-standalone-tmpfiles and systemd-standalone-sysusers, or
> ideally,
> > it would be able to guess on its own that if there are Conflicts between subpackages
> from
> > the same built, that is intentional and should be ignored.
> >
> > I looked at the docs [2, 3], but I don't see anything relevant.
> >
> > [1]
> https://src.fedoraproject.org/rpms/systemd/c/7e740c5252c3291d67def67d33e5...
> > [2] https://docs.fedoraproject.org/en-US/ci/generic_tests/#_installability
> > [3]
> https://lists.fedoraproject.org/archives/list/[e-mail]/...
> >
>
>  Hi Zbigniew,
>
>  The rpm-install-test job is using this role:
>
>
> https://pagure.io/zuul-distro-jobs/blob/master/f/roles/repo-install-rpm/t...
>
>  It seems like a good idea to add a variable to add exclude arguments to the
>  repoquery command L15. Would that work for you?
>
>  Regards,
>  -Tristan 
I went ahead and proposed those changes I think should fix systemd rpm-install-test:

  https://pagure.io/zuul-distro-jobs/pull-request/94
  https://pagure.io/fedora-zuul-jobs-config/pull-request/108

-Tristan