Code review for new CI test

[Tom Stellard]

Hi,

I wrote a CI test for the clang package, and I was wondering if someone
could review it and let me know if I have done it correctly:

https://src.fedoraproject.org/rpms/clang/pull-request/6

Thanks,
Tom

[Petr Šplíchal]

Hi Tom,

in general your test looks fine. However there are some essential
points missing. In order to enable the automation to correctly
identify failures the Standard Test Interface [1] defines how the
results should be presented:

MUST place the main readable output of the test suite into a test.log
file in the artifacts variable folder. This MUST happen even if some
of the test suites fail.
MUST return a zero exit code of the playbook if the test result is a
pass, or a non-zero exit code if the test result is a fail.

Perhaps the second point is right, but it's not clear from the pull
request. You might want to use the Standard Test Roles [2] to make
this easier. I guess the basic role would be the best candidate for
your case. You can find some more example on the Tests wiki [3].

psss...

[1] https://fedoraproject.org/wiki/CI/Standard_Test_Interface
[2] https://fedoraproject.org/wiki/CI/Standard_Test_Roles
[3] https://fedoraproject.org/wiki/CI/Tests

On 19 January 2018 at 20:40, Tom Stellard <tstellar(a)redhat.com&gt; wrote:
> Hi,
>
> I wrote a CI test for the clang package, and I was wondering if someone
> could review it and let me know if I have done it correctly:
>
> https://src.fedoraproject.org/rpms/clang/pull-request/6
>
> Thanks,
> Tom
> _______________________________________________
> CI mailing list -- ci(a)lists.fedoraproject.org
> To unsubscribe send an email to ci-leave(a)lists.fedoraproject.org