Hi all,
Please test it and report any issues.
https://github.com/fedora-cloud/cloudtoserver
Kushal
Hi
On Fri, Oct 10, 2014 at 12:19 PM, Kushal Das wrote:
Hi all,
Please test it and report any issues.
A few quick comments after glancing at the script:
Might want to suggest using fpaste instead of just paste.fedoraproject.org. You also want to fallback to calling dnf if yum doesn't exist which can happen in a future release. Consider python 3 is soon going to be the default, it might be better to make the script Python 3 compatible. Does this handle the case where a user accidentally enters something other than y or n when prompted (c.f what yum does) ?
Rahul
Hi
On Sun, Oct 12, 2014 at 3:39 PM, Rahul Sundaram wrote:
Consider python 3 is soon going to be the default, it might be better to make the script Python 3 compatible.
This was easy enough to do
https://github.com/fedora-cloud/cloudtoserver/pull/3
Rahul
Works for me, I like the fact that the script is limited to Python standard library not to add new dependencies.
Few considerations: 1. there were some discussions about dropping Python from the base cloud image. The rationale was to get the smallest viable image for most usage, not everyone uses Python. There are two blockers: cloud-init (could be replaced by min-cloud-agent), yum (could be replaced by a libhif-based alternative or already replaced by rpm-ostree/docker in the Atomic image) Note that we could provide different image flavours including one with Python. 2. If we're gonna use yum/dnf, I suggest using the API https://github.com/fedora-cloud/cloudtoserver/pull/2 3. I don't like hard-coding packages to be installed/removed/etc ... in the script. I suggest that we use a configuration file, could be shipped in the package or retrieved online (if you have no network, you can't adopt your cattle anyway :) ) 4. If the processing of adopting your cattle, it would be interesting to allow users select server roles to be installed.
H.
On Mon, Oct 13, 2014 at 5:51 AM, Haïkel hguemar@fedoraproject.org wrote:
Works for me, I like the fact that the script is limited to Python standard library not to add new dependencies.
Few considerations:
- there were some discussions about dropping Python from the base
cloud image. The rationale was to get the smallest viable image for most usage, not everyone uses Python. There are two blockers: cloud-init (could be replaced by min-cloud-agent), yum (could be replaced by a libhif-based alternative or already replaced by rpm-ostree/docker in the Atomic image) Note that we could provide different image flavours including one with Python.
Understood, I am sure we will discuss more on this in a different thread :)
- If we're gonna use yum/dnf, I suggest using the API
The only reason I never used the raw API because I do not want to reimplement the swap logic in my code. It is easier to use the system commands directly and I have other projects which showed this can be easier to maintain.
Note: The biggest reason to avoid system commands through shell is performance, which is not a problem in our case.
- I don't like hard-coding packages to be installed/removed/etc ...
in the script. I suggest that we use a configuration file, could be shipped in the package or retrieved online (if you have no network, you can't adopt your cattle anyway :) )
I agree, /etc/cloudtoserver.conf is this filename sounds good?
- If the processing of adopting your cattle, it would be interesting
to allow users select server roles to be installed.
Okay, I will ping you to know more on this.
Kushal
Hi
On Mon, Oct 13, 2014 at 12:43 AM, Kushal Das wrote:
I agree, /etc/cloudtoserver.conf is this filename sounds good?
If you want to be compatible with
http://0pointer.net/blog/projects/stateless.html
Do note:
"When you need configuration files in /etc to work properly, consider changing your application to work nicely when these files are missing, and automatically fall back to either built-in defaults, or to static vendor-supplied configuration files shipped in /usr, so that administrators can override configuration in /etc but if they don't the default configuration counts."
Rahul
On Mon, Oct 13, 2014 at 11:03 AM, Rahul Sundaram metherid@gmail.com wrote:
Hi
On Mon, Oct 13, 2014 at 12:43 AM, Kushal Das wrote:
I agree, /etc/cloudtoserver.conf is this filename sounds good?
If you want to be compatible with
http://0pointer.net/blog/projects/stateless.html
Do note:
"When you need configuration files in /etc to work properly, consider changing your application to work nicely when these files are missing, and automatically fall back to either built-in defaults, or to static vendor-supplied configuration files shipped in /usr, so that administrators can override configuration in /etc but if they don't the default configuration counts."
Thanks, I will keep these in mind.
Kushal
On Mon, Oct 13, 2014 at 02:21:19AM +0200, Haïkel wrote:
- there were some discussions about dropping Python from the base
cloud image. The rationale was to get the smallest viable image for most usage, not everyone uses Python. There are two blockers: cloud-init (could be replaced by min-cloud-agent), yum (could be replaced by a libhif-based alternative or already replaced by rpm-ostree/docker in the Atomic image) Note that we could provide different image flavours including one with Python.
This is okay; I don't think we'll include this script on the image itself; installing it and any dependencies will be part of the process.
2014-10-13 16:49 GMT+02:00 Matthew Miller mattdm@fedoraproject.org:
This is okay; I don't think we'll include this script on the image itself; installing it and any dependencies will be part of the process.
*nods* Besides, nothing has been decided yet on that point.
On Mon, Oct 13, 2014 at 10:49:31AM -0400, Matthew Miller wrote:
On Mon, Oct 13, 2014 at 02:21:19AM +0200, Haïkel wrote:
- there were some discussions about dropping Python from the base
cloud image. The rationale was to get the smallest viable image for most usage, not everyone uses Python. There are two blockers: cloud-init (could be replaced by min-cloud-agent), yum (could be replaced by a libhif-based alternative or already replaced by rpm-ostree/docker in the Atomic image) Note that we could provide different image flavours including one with Python.
This is okay; I don't think we'll include this script on the image itself; installing it and any dependencies will be part of the process.
-- Matthew Miller mattdm@fedoraproject.org Fedora Project Leader
In case we wanted to have it on the image or not have any deps, I ported it to bash [0].
[0] https://gist.github.com/Rorosha/55746a17738343c920d7
2014-10-13 17:14 GMT+02:00 Mike Ruckman roshi@fedoraproject.org:
In case we wanted to have it on the image or not have any deps, I ported it to bash [0].
sed -i '#/bin/bash#/bin/sh#' It has no bashims and I tested it against dash so it's already future-proof if we move to another default shell.
H.
On Mon, Oct 13, 2014 at 05:37:20PM +0200, Haïkel wrote:
2014-10-13 17:14 GMT+02:00 Mike Ruckman roshi@fedoraproject.org:
In case we wanted to have it on the image or not have any deps, I ported it to bash [0].
sed -i '#/bin/bash#/bin/sh#' It has no bashims and I tested it against dash so it's already future-proof if we move to another default shell.
H.
I updated the gist. I can throw it in a repo or package it up if it's something useful. Thanks for checking it out :)
----- Original Message -----
Hi all,
Please test it and report any issues.
Hi, could you please update https://bugzilla.redhat.com/show_bug.cgi?id=1090886 and https://fedoraproject.org/wiki/Changes/Convert_Fedora_Cloud_Image_to_Fedora_... with details?
The changes deadline is tomorrow. Also, updates for any other changes from Server and Cloud WGs are welcome :). There are several, trying to ping right folks right now.
Thanks Jaroslav
Kushal
CPython Core Developer http://fedoraproject.org http://kushaldas.in _______________________________________________ server mailing list server@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/server