On 01/20/2012 01:37 PM, Russell Bryant wrote:
On Jan 20, 2012, at 7:48 AM, Derek Higgins <derekh(a)redhat.com> wrote:
> Hi Russell,
> While writing automation scripts for installing nova, I am running
>
> $ openstack-nova-db-setup --novapw nova --rootpw "" --yes
>
> my problem is this script prompts for a password if the mysql root
> password is a zero length string. This patch allows the root password to
> be a zero length string.
>
> Any thought? should this change go into the openstack-nova package or is
> it a bad idea to allow blank passwords?
>
> in my case mysql had already been installed with a blank root password
> before running this script so I had to pass in the blank password.
>
This change looks good to me. This just wasn't a case I thought about. I can merge
the patch next week if someone else doesn't beat me to it.
I agree with the change too.
I'll merge now.
I was also thinking of adding a "chkconfig mysqld on" to the script.
cheers,
Pádraig.