All,
At the last SIG meeting I agreed to have a go at fixing up the cloud spin and the associated kickstarts. As I understand it, this means:
* Changes to comps - Specifically adding a group that carries the necessary enabling packages that need to be in the cloud image
* Changes to the cloud kickstarts - To use the above comps groups, rather than individual packages
* Changes to the spin/install file - To pull in the enabling packages needed in the cloud image builds, so that the images can be built successfully using the Cloud install tree
With the above in mind, here is my work so far (on github because they do such a nice job of rendering diffs, and because I don't have commit access to the Fedora repos):
* comps changes - https://github.com/imcleod/comps-imcleod/compare/feature/cloud-updates
* kickstart and spin changes - https://github.com/imcleod/spin-kickstarts/compare/feature/cloud-changes
Thoughts?
If these are acceptable, and given that the existing cloud tree is, apparently, broken, can we push out the changes and then deal with any follow on issues as they show up in the nightly builds?
-Ian
On Mon, Sep 08, 2014 at 02:29:34PM -0500, Ian McLeod wrote:
- comps changes -
https://github.com/imcleod/comps-imcleod/compare/feature/cloud-updates
- kickstart and spin changes -
https://github.com/imcleod/spin-kickstarts/compare/feature/cloud-changes
Thoughts?
If these are acceptable, and given that the existing cloud tree is, apparently, broken, can we push out the changes and then deal with any follow on issues as they show up in the nightly builds?
I can (and did) commit the spin-kickstart changes, but not the comps ones (at least not without abusing my FPL powers). I think that's still in Bill Nottingham's hands and should be done as a bug in bugzilla?
Matthew Miller (mattdm@fedoraproject.org) said:
On Mon, Sep 08, 2014 at 02:29:34PM -0500, Ian McLeod wrote:
- comps changes -
https://github.com/imcleod/comps-imcleod/compare/feature/cloud-updates
- kickstart and spin changes -
https://github.com/imcleod/spin-kickstarts/compare/feature/cloud-changes
Thoughts?
If these are acceptable, and given that the existing cloud tree is, apparently, broken, can we push out the changes and then deal with any follow on issues as they show up in the nightly builds?
I can (and did) commit the spin-kickstart changes, but not the comps ones (at least not without abusing my FPL powers). I think that's still in Bill Nottingham's hands and should be done as a bug in bugzilla?
comps is open to packager, you can push at will. If you're asking for *review*, the changes look generally OK to me. If you're only adding the groups and not adding them to any environments, they won't be selectable in the anaconda UI, but I think that's OK for cloud stuff.
Bill
On Tue, Sep 09, 2014 at 03:07:35PM -0400, Bill Nottingham wrote:
comps is open to packager, you can push at will. If you're asking for *review*, the changes look generally OK to me. If you're only adding the groups and not adding them to any environments, they won't be selectable in the anaconda UI, but I think that's OK for cloud stuff.
Ah, okay. Ian, do you want to go ahead and do it?
Based on discussion on the cloud list, I guess we _do_ want an environment, but that's a separable concern from "getting it working in kickstart".
On Mon, Sep 08, 2014 at 02:29:34PM -0500, Ian McLeod wrote:
https://github.com/imcleod/comps-imcleod/compare/feature/cloud-updates https://github.com/imcleod/spin-kickstarts/compare/feature/cloud-changes
PS:
https://github.com/imcleod/spin-kickstarts/compare/feature/cloud-changes.dif... https://github.com/imcleod/comps-imcleod/compare/feature/cloud-updates.diff
to get these in patch form, for anyone unfamiliar with github.
Ian -- what about the change to spin/install?
-
Bill Nottingham -
Ian McLeod -
Matthew Miller