[gfs2-utils] branch main updated: Excplicitly ignore posix_fadvise()
return value
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
andyp pushed a commit to branch main
in repository gfs2-utils.
The following commit(s) were added to refs/heads/main by this push:
new a6a660fb Excplicitly ignore posix_fadvise() return value
a6a660fb is described below
commit a6a660fbd51ecd5bb6e6bd99b93c5d0857f09308
Author: Andrew Price <anprice(a)redhat.com>
AuthorDate: Thu Mar 3 17:13:01 2022 +0000
Excplicitly ignore posix_fadvise() return value
Static analysis complains that we don't check the return value but as
it's just advisory readahead we don't care about it. Make that explicit
and silence the warnings by casting to void.
Signed-off-by: Andrew Price <anprice(a)redhat.com>
---
gfs2/fsck/initialize.c | 8 ++++----
gfs2/fsck/metawalk.c | 18 +++++++++---------
gfs2/fsck/pass1.c | 2 +-
gfs2/mkfs/main_mkfs.c | 2 +-
4 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/gfs2/fsck/initialize.c b/gfs2/fsck/initialize.c
index 942a2de8..eade7f3c 100644
--- a/gfs2/fsck/initialize.c
+++ b/gfs2/fsck/initialize.c
@@ -640,7 +640,7 @@ static unsigned gfs2_rgrp_reada(struct lgfs2_sbd *sdp, unsigned cur_window,
rgd = (struct lgfs2_rgrp_tree *)n;
start = rgd->rt_addr * sdp->sd_bsize;
len = rgd->rt_length * sdp->sd_bsize;
- posix_fadvise(sdp->device_fd, start, len, POSIX_FADV_WILLNEED);
+ (void)posix_fadvise(sdp->device_fd, start, len, POSIX_FADV_WILLNEED);
}
return i;
@@ -666,7 +666,7 @@ static int read_rgrps(struct lgfs2_sbd *sdp, uint64_t expected)
unsigned ra_window = 0;
/* Turn off generic readhead */
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_RANDOM);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_RANDOM);
for (n = osi_first(&sdp->rgtree); n; n = next) {
next = osi_next(n);
@@ -688,11 +688,11 @@ static int read_rgrps(struct lgfs2_sbd *sdp, uint64_t expected)
if (count != expected)
goto fail;
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
return 0;
fail:
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
lgfs2_rgrp_free(sdp, &sdp->rgtree);
return -1;
}
diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index cdbeec9d..9c8d857b 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -674,7 +674,7 @@ static void dir_leaf_reada(struct lgfs2_inode *ip, __be64 *tbl, unsigned hsize)
}
qsort(t, n, sizeof(uint64_t), u64cmp);
for (i = 0; i < n; i++)
- posix_fadvise(sdp->device_fd, t[i], sdp->sd_bsize, POSIX_FADV_WILLNEED);
+ (void)posix_fadvise(sdp->device_fd, t[i], sdp->sd_bsize, POSIX_FADV_WILLNEED);
}
/* Checks exhash directory entries */
@@ -702,7 +702,7 @@ int check_leaf_blks(struct lgfs2_inode *ip, struct metawalk_fxns *pass)
orig_di_blocks = ip->i_blocks;
/* Turn off system readahead */
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_RANDOM);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_RANDOM);
/* Readahead */
dir_leaf_reada(ip, tbl, hsize);
@@ -711,7 +711,7 @@ int check_leaf_blks(struct lgfs2_inode *ip, struct metawalk_fxns *pass)
error = pass->check_hash_tbl(ip, tbl, hsize, pass->private);
if (error < 0) {
free(tbl);
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
return error;
}
/* If hash table changes were made, read it in again. */
@@ -746,7 +746,7 @@ int check_leaf_blks(struct lgfs2_inode *ip, struct metawalk_fxns *pass)
log_err(_("Directory #%"PRIu64" (0x%"PRIx64") has no valid leaf blocks\n"),
ip->i_num.in_addr, ip->i_num.in_addr);
free(tbl);
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
return 1;
}
lindex = 0;
@@ -790,7 +790,7 @@ int check_leaf_blks(struct lgfs2_inode *ip, struct metawalk_fxns *pass)
struct lgfs2_leaf leaf;
if (fsck_abort) {
free(tbl);
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
return 0;
}
error = check_leaf(ip, lindex, pass, &leaf_no, &leaf,
@@ -832,7 +832,7 @@ int check_leaf_blks(struct lgfs2_inode *ip, struct metawalk_fxns *pass)
lindex += ref_count;
} /* for every leaf block */
free(tbl);
- posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
+ (void)posix_fadvise(sdp->device_fd, 0, 0, POSIX_FADV_NORMAL);
return 0;
}
@@ -1111,7 +1111,7 @@ static void file_ra(struct lgfs2_inode *ip, struct lgfs2_buffer_head *bh,
block = be64_to_cpu(*p);
extlen = block - sblock;
if (extlen > 1 && extlen <= maxptrs) {
- posix_fadvise(sdp->device_fd,
+ (void)posix_fadvise(sdp->device_fd,
sblock * sdp->sd_bsize,
(extlen + 1) * sdp->sd_bsize,
POSIX_FADV_WILLNEED);
@@ -1137,7 +1137,7 @@ static void file_ra(struct lgfs2_inode *ip, struct lgfs2_buffer_head *bh,
if (extlen && sblock) {
if (extlen > 1)
extlen--;
- posix_fadvise(sdp->device_fd, sblock * sdp->sd_bsize,
+ (void)posix_fadvise(sdp->device_fd, sblock * sdp->sd_bsize,
extlen * sdp->sd_bsize,
POSIX_FADV_WILLNEED);
extlen = 0;
@@ -1145,7 +1145,7 @@ static void file_ra(struct lgfs2_inode *ip, struct lgfs2_buffer_head *bh,
}
}
if (extlen)
- posix_fadvise(sdp->device_fd, sblock * sdp->sd_bsize,
+ (void)posix_fadvise(sdp->device_fd, sblock * sdp->sd_bsize,
extlen * sdp->sd_bsize, POSIX_FADV_WILLNEED);
}
diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck/pass1.c
index 78347105..1ee10795 100644
--- a/gfs2/fsck/pass1.c
+++ b/gfs2/fsck/pass1.c
@@ -1719,7 +1719,7 @@ static int pass1_process_bitmap(struct lgfs2_sbd *sdp, struct lgfs2_rgrp_tree *r
block = ibuf[i];
if (r++ == rawin) {
- posix_fadvise(sdp->device_fd, block * sdp->sd_bsize, ralen, POSIX_FADV_WILLNEED);
+ (void)posix_fadvise(sdp->device_fd, block * sdp->sd_bsize, ralen, POSIX_FADV_WILLNEED);
r = 0;
}
diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c
index f72f7e17..07e0befa 100644
--- a/gfs2/mkfs/main_mkfs.c
+++ b/gfs2/mkfs/main_mkfs.c
@@ -1168,7 +1168,7 @@ static int open_dev(struct mkfs_dev *dev, int withprobe)
}
/* Freshen up the cache */
- posix_fadvise(dev->fd, 0, 0, POSIX_FADV_DONTNEED);
+ (void)posix_fadvise(dev->fd, 0, 0, POSIX_FADV_DONTNEED);
error = fstat(dev->fd, &dev->stat);
if (error < 0) {
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
2 years, 1 month
[gfs2-utils] branch main updated (08b1f7eb -> 7cc73658)
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
andyp pushed a change to branch main
in repository gfs2-utils.
from 08b1f7eb build: allow testvol location to be configurable.
add eab8bbe8 tests: Regenerate testvol where needed
add 7cc73658 tests: Add an option to clean up the testvol file unconditionally
No new revisions were added by this update.
Summary of changes:
tests/atlocal.in | 9 +++++++++
tests/mkfs.at | 6 ++++++
tests/testsuite.at | 5 ++++-
tests/tune.at | 2 ++
4 files changed, 21 insertions(+), 1 deletion(-)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
2 years, 1 month
