Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=58bf864d8a6... Commit: 58bf864d8a6da5a1013280c767ec166c28cbcf55 Parent: 286a02668d6433cd62faf2ebb212bb4203f9f2c8 Author: Bob Peterson rpeterso@redhat.com AuthorDate: Fri Jan 23 09:12:57 2015 -0600 Committer: Bob Peterson rpeterso@redhat.com CommitterDate: Fri Feb 13 08:34:31 2015 -0600
fsck.gfs2: Fix journal sequence number reporting problem
This bug was spotted by coverity. The fsck.gfs2 should include a line to report the number of journal sequence errors fixed. It was coded improperly so that it was never displayed. This patch fixes the code so that the message will be printed properly. --- gfs2/fsck/fs_recovery.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/gfs2/fsck/fs_recovery.c b/gfs2/fsck/fs_recovery.c index abb8187..9be5a95 100644 --- a/gfs2/fsck/fs_recovery.c +++ b/gfs2/fsck/fs_recovery.c @@ -436,10 +436,9 @@ static int check_journal_seq_no(struct gfs2_inode *ip, int fix) (unsigned long long)lowest_seq, (unsigned long long)highest_seq, (unsigned long long)prev_seq); - if (!fix) { - seq_errors++; + seq_errors++; + if (!fix) continue; - } highest_seq++; lh.lh_sequence = highest_seq; prev_seq = lh.lh_sequence; @@ -449,8 +448,10 @@ static int check_journal_seq_no(struct gfs2_inode *ip, int fix) gfs2_log_header_out(&lh, bh); brelse(bh); } - if (seq_errors && fix) + if (seq_errors && fix) { log_err(_("%d sequence errors fixed.\n"), seq_errors); + seq_errors = 0; + } return seq_errors; }