Re: How to use VARIANT_ID to change branding folder that is searched?

[Lars Karlitski]

Systems should not override it according to the spec. It's supposed to be a symlink to `/usr/lib/os-release`. The idea is that you can override it in `/etc`.

Unfortunately, some systems get this wrong and ony write the file in `/etc`. (RHEL for example)

On Sun, Dec 15, 2019, at 21:19, Daniel Hilst wrote:
> Hi Lars,
>
> Yeah I just figured this out, is it okay to edit this file? A system update wouldn't overwrite it?
>
> Regards
>
> *De:* Lars Karlitski 
> *Enviado:* domingo, 15 de dezembro de 2019 07:30
> *Para:* [e-mail] 
> *Assunto:* Re: How to use VARIANT_ID to change branding folder that is searched?
>
> Hi Daniel,
>
> Cockpit looks in `/etc/os-release`[1] for the `VARIANT` and `VARIANT_ID` keys. You can override the keys there.
>
> Lars
>
> [1]  https://www.freedesktop.org/software/systemd/man/os-release.html
>
> On Sat, Dec 14, 2019, at 20:27, Daniel Hilst wrote:
> > Hi
> >
> > I'm trying to change the branding folder that is used by cockpit, I read this in at  https://github.com/cockpit-project/cockpit/blob/master/doc/branding.md#how-c...
> >
> > I tried by placing it at systemd unit file, here is how
> >
> > # cat /etc/systemd/system/cockpit.service 
> > [Unit]
> > Description=Cockpit Web Service
> > Documentation=man:cockpit-ws(8)
> > Requires=cockpit.socket
> >
> > [Service]
> > ExecStartPre=/usr/sbin/remotectl certificate --ensure --user=root --group=cockpit-ws --selinux-type=etc_t
> > ExecStart=/usr/libexec/cockpit-ws
> > PermissionsStartOnly=true
> > User=cockpit-ws
> > Group=cockpit-ws
> > Environment=VARIANT_ID=MyVariant #<-- my variant
> >
> > Also I tried to stop cockpit.service and run with the variable setted, no effect
> >
> > I copied centos folder to centos-MyVariant and changed the logo image. I expected to see the new image, but nothing changed
> >
> > Any ideas? What I'm missing?
> >
> > cockpit-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: https://lists.fedorahosted.org/archives/list/[e-mail]...
>
> cockpit-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedorahosted.org/archives/list/[e-mail]...

How to use VARIANT_ID to change branding folder that is searched?

[Daniel Hilst]

Thanks for your reply Lars,

I'm sed'ing this file during the installation, it is working so far :)

Regards
________________________________
De: Lars Karlitski 
Enviado: domingo, 15 de dezembro de 2019 19:56
Para: Daniel Hilst ; Development discussion for the Cockpit Project 
Assunto: Re: How to use VARIANT_ID to change branding folder that is searched?

Systems should not override it according to the spec. It's supposed to be a symlink to `/usr/lib/os-release`. The idea is that you can override it in `/etc`.

Unfortunately, some systems get this wrong and ony write the file in `/etc`. (RHEL for example)

On Sun, Dec 15, 2019, at 21:19, Daniel Hilst wrote:
Hi Lars,

Yeah I just figured this out, is it okay to edit this file? A system update wouldn't overwrite it?

Regards

________________________________

De: Lars Karlitski 
Enviado: domingo, 15 de dezembro de 2019 07:30
Para: [e-mail] 
Assunto: Re: How to use VARIANT_ID to change branding folder that is searched?

Hi Daniel,

Cockpit looks in `/etc/os-release`[1] for the `VARIANT` and `VARIANT_ID` keys. You can override the keys there.

Lars

[1] https://www.freedesktop.org/software/systemd/man/os-release.html

On Sat, Dec 14, 2019, at 20:27, Daniel Hilst wrote:
Hi

I'm trying to change the branding folder that is used by cockpit, I read this in at https://github.com/cockpit-project/cockpit/blob/master/doc/branding.md#how-c...

I tried by placing it at systemd unit file, here is how

# cat /etc/systemd/system/cockpit.service
[Unit]
Description=Cockpit Web Service
Documentation=man:cockpit-ws(8)
Requires=cockpit.socket

[Service]
ExecStartPre=/usr/sbin/remotectl certificate --ensure --user=root --group=cockpit-ws --selinux-type=etc_t
ExecStart=/usr/libexec/cockpit-ws
PermissionsStartOnly=true
User=cockpit-ws
Group=cockpit-ws
Environment=VARIANT_ID=MyVariant #<-- my variant

Also I tried to stop cockpit.service and run with the variable setted, no effect

I copied centos folder to centos-MyVariant and changed the logo image. I expected to see the new image, but nothing changed

Any ideas? What I'm missing?

_______________________________________________
cockpit-devel mailing list -- [e-mail]
To unsubscribe send an email to [e-mail]
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/[e-mail]...

_______________________________________________
cockpit-devel mailing list -- [e-mail]
To unsubscribe send an email to [e-mail]
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/[e-mail]...