https://bugzilla.redhat.com/show_bug.cgi?id=1445784
Honza Horak <hhorak(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review+
--- Comment #1 from Honza Horak <hhorak(a)redhat.com> ---
Two issues spotted:
1) The image is s2i (which is correct), but uses
FROM
registry.fedoraproject.org/fedora:25
..which would duplicate common s2i stuff. I'd suggest to use s2i-base as the
base image:
FROM
registry.fedoraproject.org/f25/s2i-base
2) MAINTAINER statement is obsolete, we should use LABEL MAINTAINER instead.
But none of them is a blocker for the review, so IMO we can ack this.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Fe5aj5Mhah&a=cc_unsubscribe