https://bugzilla.redhat.com/show_bug.cgi?id=1444091
Jan Koscielniak <jkosciel(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |phracek(a)redhat.com
Flags| |needinfo?(phracek(a)redhat.co
| |m)
--- Comment #1 from Jan Koscielniak <jkosciel(a)redhat.com> ---
I reviewed the container and here's some issues I found:
Volume description in help file [1], especially these points:
- "All volumes listed in the Dockerfile must be listed in the Help File."
- "Each volume in the Help File must have the following: The full path of the
volume and Why it is marked a volume "
And here's something that is not necessary, but more of a best practice:
I'd suggest moving the VERSION and RELEASE to ENV section, because if either of
them were to change, you would have to modify the Dockerfile, instead of just
modifying the command used to build it.
see [2]
[1]
https://fedoraproject.org/wiki/Container:Guidelines#Volumes
[2]
https://fedoraproject.org/wiki/Container:Guidelines#VERSIONING
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ZSgiec8d2u&a=cc_unsubscribe