[Bug 1645112] New: Container Review Request: origin-tests - origin-tests image

https://bugzilla.redhat.com/show_bug.cgi?id=1645112

            Bug ID: 1645112
           Summary: Container Review Request: origin-tests - origin-tests
                    image
           Product: Fedora Container Images
           Version: rawhide
         Component: Container Review
          Assignee: nobody(a)fedoraproject.org
          Reporter: jcajka(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: container-review(a)lists.fedoraproject.org



Container Build Info URL:
https://pagure.io/origin-dockerfiles/blob/master/f/3.11/tests/Dockerfile
Description: This is the official OpenShift test image. It can be used to
verify  an installation of OpenShift completed successfully.
Fedora Account System Username: jcajka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fPgePYmXZH&a=cc_unsubscribe

[Bug 1645112] Container Review Request: origin-tests - origin-tests image

https://bugzilla.redhat.com/show_bug.cgi?id=1645112

Tomas Tomecek <ttomecek(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |ttomecek(a)redhat.com
           Assignee|nobody(a)fedoraproject.org    |ttomecek(a)redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=JJX6NiSmif&a=cc_unsubscribe

[Bug 1645112] Container Review Request: origin-tests - origin-tests image

https://bugzilla.redhat.com/show_bug.cgi?id=1645112

Tomas Tomecek <ttomecek(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review?



--- Comment #1 from Tomas Tomecek <ttomecek(a)redhat.com&gt; ---
```
# FROM registry.fedoraproject.org/f29/origin-cli
FROM origin-cli
```

Shouldn't this be set to the line which is commented out? Or did we finally got
rid of the $FGC prefix?

Actually, the same question, are we still doing FGC? `name="$FGC/$NAME" \`?


Otherwise LGTM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mYTQeCgTAB&a=cc_unsubscribe

[Bug 1645112] Container Review Request: origin-tests - origin-tests image

https://bugzilla.redhat.com/show_bug.cgi?id=1645112



--- Comment #2 from Jakub Čajka <jcajka(a)redhat.com&gt; ---
(In reply to Tomas Tomecek from comment #1)
>  ```
>  # FROM registry.fedoraproject.org/f29/origin-cli
>  FROM origin-cli
>  ```
>  
>  Shouldn't this be set to the line which is commented out? Or did we finally
>  got rid of the $FGC prefix?
>  
>  Actually, the same question, are we still doing FGC? `name="$FGC/$NAME" \`?
>  
>  
>  Otherwise LGTM. 
Yes, it will be the commented when the cli image will be in Fedora. You can
build the whole stack using the build.sh script, although it might fail on some
as they are waiting for latest origin package to hit stable in F29.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=W0A6ISlZv9&a=cc_unsubscribe

[Bug 1645112] Container Review Request: origin-tests - origin-tests image

https://bugzilla.redhat.com/show_bug.cgi?id=1645112

Tomas Tomecek <ttomecek(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Tomas Tomecek <ttomecek(a)redhat.com&gt; ---
LGTM, approving

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=xruPNQLiRi&a=cc_unsubscribe

[Bug 1645112] Container Review Request: origin-tests - origin-tests image

https://bugzilla.redhat.com/show_bug.cgi?id=1645112



--- Comment #4 from Gwyn Ciesla <limburgher(a)gmail.com&gt; ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/container/origin-tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=lDxMZMgF0z&a=cc_unsubscribe