[Bug 1427989] New: Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

            Bug ID: 1427989
           Summary: Container Review Request - python-classroom -
                    Container for teaching and learning Python
           Product: Fedora Docker Images
           Version: rawhide
         Component: Container Review
          Assignee: nobody(a)fedoraproject.org
          Reporter: torsava(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: container-review(a)lists.fedoraproject.org



Container Build Info URL: https://github.com/torsava/python-classroom
Description: Ready to use container for teaching and learning Python
Fedora Account System Username: torsava

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ehIgdlj4RO&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

Mike Ruckman <mruckman(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mruckman(a)redhat.com



--- Comment #1 from Mike Ruckman <mruckman(a)redhat.com&gt; ---
On line 4, you should put "noarch" (same as for packages)

Line 15, I don't think you actually need this CMD. I'd assume most people will
launch the container with something like "-i -t container /bin/bash" anyways,
right?

Otherwise, LGTM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=KfRAbJJidF&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989



--- Comment #2 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
Wouldn't the CMD be helpful if they forget? (But I'm ok with removing if
that's
the common practice.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vjxdHYJbWB&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989



--- Comment #3 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
Added noarch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ncbABhZgy8&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989



--- Comment #4 from Tomas Orsava <torsava(a)redhat.com&gt; ---
(In reply to Mike Ruckman from comment #1)
>  On line 4, you should put "noarch" (same as for packages)
The guidelines say:

"Architecture the software in the image should target (Optional: if omitted, it
will be built for all supported Fedora Architectures)"

Which is why I left it empty originally. It's changed now.

>  Line 15, I don't think you actually need this CMD. I'd assume
> most people
>  will launch the container with something like "-i -t container /bin/bash"
>  anyways, right? 
Yes, I added it just so that it can be run with less flags on the command line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=uwEGhu3pU2&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989



--- Comment #5 from Mike Ruckman <mruckman(a)redhat.com&gt; ---
This looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=hv006IU4jv&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

Dusty Mabe <dustymabe(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dustymabe(a)redhat.com
              Flags|                            |needinfo+



--- Comment #6 from Dusty Mabe <dustymabe(a)redhat.com&gt; ---
LGTM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HindHLzUCz&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

James Hogarth <james.hogarth(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |james.hogarth(a)gmail.com,
                   |                            |package-review(a)lists.fedora
                   |                            |project.org
          Component|Container Review            |Package Review
            Version|rawhide                     |25
            Product|Fedora Docker Images        |Fedora
              Flags|needinfo+                   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=I98WddkRQt&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

James Hogarth <james.hogarth(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|25                          |rawhide



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XS96pvOsMt&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

James Hogarth <james.hogarth(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody(a)fedoraproject.org    |james.hogarth(a)gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=tRXFxOxDm7&a=cc_unsubscribe

[Bug 1427989] Container Review Request - python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

James Hogarth <james.hogarth(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #7 from James Hogarth <james.hogarth(a)gmail.com&gt; ---
Marking APPROVED after discussion in #fedora-cloud

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=jHo896Rgr3&a=cc_unsubscribe

[Bug 1427989] Container Review Request: python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Container Review Request -  |Container Review Request:
                   |python-classroom -          |python-classroom -
                   |Container for teaching and  |Container for teaching and
                   |learning Python             |learning Python



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=AX4G2at5Ag&a=cc_unsubscribe

[Bug 1427989] Container Review Request: python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989



--- Comment #8 from Jon Ciesla <limburgher(a)gmail.com&gt; ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/docker/python-classroom

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=X4wcm8OlHe&a=cc_unsubscribe

[Bug 1427989] Container Review Request: python-classroom - Container for teaching and learning Python

https://bugzilla.redhat.com/show_bug.cgi?id=1427989

Dusty Mabe <dustymabe(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2017-11-06 11:56:40



--- Comment #9 from Dusty Mabe <dustymabe(a)redhat.com&gt; ---
closing this since it seems to have made it into dist-git: 
https://src.fedoraproject.org/container/python-classroom

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=GXwRf4zUOu&a=cc_unsubscribe